Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-help): nonsense prepended when copying message #9484

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Aug 11, 2023

Summary

Problem

often when highlighting text to copy from ai help, something like this gets prepended:

Avatar
9901f5c4d49546998c4138f6d7759b46

Solution

the avatar component was defining pretty meaningless alt text, I've removed that, and added more meaningful alt text to the user menu


How did you test this change?

  • copied before/after
  • checked the user menu button still got text in Firefox's accessibility devtools

often when highlighting text to copy from ai help, something like this
gets prepended:
Avatar
9901f5c4d49546998c4138f6d7759b46

the avatar component was defining pretty meaningless alt text, I've
removed that, and added more meaningful alt text to the user menu
@LeoMcA LeoMcA requested a review from caugner August 11, 2023 17:23
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LeoMcA LeoMcA merged commit 117f5bf into main Aug 14, 2023
13 checks passed
@LeoMcA LeoMcA deleted the fix-avatar-copy branch August 14, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants