fix(layout): consolidate sticky header #8781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `--sticky-header-height` everywhere
|
This is breaking the ToC (breaking it more). Working on a fix 😮💨 |
caugner
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
use
--sticky-header-heighteverywhere(MP-165 + MP-156)
Problem
On prod when scrolling on an article page the toc is moving by 2px because the offset was wrong. This is worse on staging with the top banner.
Solution
Consolidate the offset to use
-sticky-header-height. This should fix the issue at hand without touching to much of our fragile CSS.Screenshots
Before
After