-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Persist language selection #5498
Comments
I am guessing you mean when leaving MDN and later returning via a search result? It seems to work fine if you change the language and navigate around MDN. Thank you for reporting @mt-webdev |
@mt-webdev Would it be a solution for you to make English the preferred language in your Chrome settings? And if not, why not? |
@schalkneethling yes, that's also a scenario where it's changing my preferences. (visit via Search-Engines) |
@mt-webdev Just to understand: Can you elaborate on why you like to keep your browser preferring a different language than you actually prefer? Are there other sites that would then appear in English, although you prefer them in the language currently preferred by your browser? (Note that, at least in Firefox, you can have the browser UI in one language and still prefer a different language.) |
I believe the problem is that the reader wants to have MDN Web Docs always in English. If they change the setting in Chrome, then I believe all(or most) websites they visit will honour the selection and always show English content. |
Yes, that is a problem we have not solved for. With that said, there is a rather old pull request that does address this: We would need to pick this up again and get it merged but, we will have to speak with the product owner to set priority for when we do this work. |
English content is usually more up-to-date, hence the preference of English on MDN, whereas the browser is set to prefer another language. In the old MDN, the problem was solved eventually by making it easy to access the English page (a link in the top right corner, "Go to English page") and IIRC the choice was saved. |
I do not believe the choice was saved but yes, the quick link to English was useful to some folks. We can solve this problem by taking the following pull request across the finish line, so to speak. #3968 We will need to prioritise the work though. @HerminaC and @fiji-flo Thoughts? |
I never noticed this "issue" while using the previous MDN version. I am not sure why I end up on (in my case) german MDN sometimes... :-/ |
Now that we also have MDN Plus in german speaking countries, can we save our preferred language in our mozilla account? |
@mt-webdev Thank you for starting this conversation. I have moved this to a discussion here: https://github.com/orgs/mdn/discussions/97 |
Summary
Unfortunately, the language selection is not being persisted, which means on every visit I have to reselect my wanted language (which is English)
Where did you spot the bug?
Literally any site:
https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector
What is the problem?
The site is currently not able to persist in the user/session settings.
What did you expect to happen?
Once I revisit the site I would like to memorize my language selection ( & theme as well, but less of a bummer)
Steps to reproduce the issue
Environment
Device
Browser
Operating system
The text was updated successfully, but these errors were encountered: