Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-help): set chatId on user message #11751

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Sep 6, 2024

Summary

(MP-658, MP-1478)

Problem

When editing a question after it was initially submitted (without reloading the page), submitting the updated question causes a new topic, because the question is missing the chatId reference.

Solution

Make sure that the chatId is set on the question, so that the re-submitted question lands in the same chat.


Screenshots

Before

Screen.Recording.2024-09-06.at.14.05.49.mov

After

Screen.Recording.2024-09-06.at.14.04.59.mov

How did you test this change?

  1. Ran yarn dev locally with Rumba running locally.
  2. Opened http://localhost:3000/en-US/plus/ai-help locally.
  3. Asked "How to center a div with CSS? Answer in one word." and waited for the response.
  4. Edited the question, then resubmitted it.
  5. Verified that the edited question remained in the same chat/tree.

@caugner caugner requested a review from a team as a code owner September 6, 2024 12:08
@github-actions github-actions bot added the plus work around features related to MDN Plus label Sep 6, 2024
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caugner caugner merged commit 97f4b23 into main Sep 6, 2024
14 checks passed
@caugner caugner deleted the MP-1478-fix-ai-help-new-topic-on-fresh-edit branch September 6, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plus:ai-help plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants