Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notecard): misaligned icon, excessive internal padding #11467

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Jul 11, 2024

Summary

Problem

Solution

  • Align icon with text
  • Override .main-page-content and dd styles (long term we need a better solution for this, it's frustrating to have to override styles, perhaps something like the notecard should live in the shadow dom?)

Screenshots

Before

image

After

image


How did you test this change?

yarn dev, clicked around a few pages

@LeoMcA LeoMcA requested a review from AnujaRajput727 July 11, 2024 16:01
@LeoMcA LeoMcA requested a review from a team as a code owner July 11, 2024 16:01
Copy link

@AnujaRajput727 AnujaRajput727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@LeoMcA LeoMcA merged commit 5bc2965 into main Jul 30, 2024
14 checks passed
@LeoMcA LeoMcA deleted the fix-notecard-icon-alignment branch July 30, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants