enhance(homepage): optimize + lazy-load contributor logo #11258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used pngquant.
It is 512px wide, not 523px.
caugner
changed the title
caugner
changed the title
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The contributor logo on the homepage is larger than it could be, and this is pointed out by Google PageSpeed Insights.
Solution
Optimize it with pngquant, effectively reducing its size by 19% from 38 to 31 kB.
Note: Also imports it (allowing a longer cache duration), fixes the declared width, and enables lazy-loading.
Screenshots
No change, see image diff in "Files changed" tab.
How did you test this change?
Ran
yarn devlocally.