fix(seo): add missing sitemaps #11234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
MP-1169-add-missing-sitemaps
branch
from
978888a to
94ee0fc
Compare
argl
approved these changes
Jun 3, 2024
|
@argl I added two commits (94ee0fc...8315619), if you want to take another quick look. |
argl
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1169)
Problem
Our sitemaps currently only cover the content pages, and don't cover Blog, Curriculum, and other pages.
Solution
Add sub-sitemaps for the Blog, the Curriculum, and miscellaneous pages, and create the sitemap index universally.
Also:
BASE_URLin the sitemaps, so that links on stage are pointing to stage.Content-Encoding: gzipheader was also set for non-existing sitemaps, causing a "Content Encoding Error" in the browser, because our HTTP 404 page isn't gzip-encoded.How did you test this change?
Ran
yarn build:blog && yarn build:curriculum && yarn tool spas && yarn build --sitemap-indexand verified the output.