chore(build): remove the redirection of legacy images that start with /@api/deki/

[yin1999]

Summary

The usage of legacy images that start with /@api/deki/ has been removed from content and translated-content (this can be checked by search the string /@api/deki in those two repos). We can now safely remove them.

Related issue: mdn/translated-content#10487

The replacement of prefix = of image file name has also been removed, I wrote a script to check all image references that contain an equal sign:

search.ts

import { fromMarkdown } from "mdast-util-from-markdown";
import { visit } from "unist-util-visit";
import fs from "node:fs/promises";
import * as path from "node:path";
import { fdir } from "fdir";
import ora from "ora";
import yargs from "yargs";
import { hideBin } from "yargs/helpers";

const ESCAPE_CHARS_RE = /[.*+?^${}()|[\]\\]/g;

function findMatchesInText(
  haystack: string,
  { attribute = null } = {}
): Set<string> {
  // Need to remove any characters that can affect a regex if we're going
  // use the string in a manually constructed regex.
  const escaped = "[^'\"]+".replace(ESCAPE_CHARS_RE, "\\$&");
  const rex = attribute
    ? new RegExp(`${attribute}=['"](${escaped})['"]`, "g")
    : new RegExp(`(${escaped})`, "g");
  const matches = new Set<string>();
  for (const match of haystack.matchAll(rex)) {
    // check if the match contains an equal sign
    if (match[0].includes("=")) {
      matches.add(match[0]);
    }
  }
  return matches;
}

export function findImagesInMarkdown(rawContent: string): Set<string> {
  const matches = new Set<string>();
  const type = "image";
  const attributeType = "src";
  const tree = fromMarkdown(rawContent);
  // Find all the links and images in the markdown
  // we should also find any HTML elements that contain links or images
  visit(tree, [type, "html"], (node) => {
    if (node.type === "html") {
      const matchesInHtml = findMatchesInText(node.value, {
        attribute: attributeType,
      });
      for (const match of matchesInHtml) {
        matches.add(match);
      }
    } else if (node.type == type && node.url.includes("=")) {
      // else this would be a markdown link or image
      matches.add(node.url);
    }
  });
  return matches;
}

const spinner = ora().start();

async function main() {
  const { argv } = yargs(hideBin(process.argv)).command(
    "$0 [files..]",
    "Check the url locales of the given files",
    (yargs) => {
      yargs.positional("files", {
        describe:
          "The files to check (relative to the current working directory)",
        type: "string",
        array: true,
        default: ["../content/files/", "../translated-content/files/"],
      });
    }
  );

  const files = [];

  spinner.text = "Crawling files...";

  for (const fp of (argv as any).files as string[]) {
    const fstats = await fs.stat(fp);

    if (fstats.isDirectory()) {
      files.push(
        ...new fdir()
          .withBasePath()
          .filter((path) => path.endsWith(".md"))
          .crawl(fp)
          .sync()
      );
    } else if (fstats.isFile()) {
      files.push(fp);
    }
  }

  let exitCode = 0;
  const results = new Map<string, Set<string>>();

  for (const i in files) {
    const file = files[i];

    spinner.text = `${i}/${files.length}: ${file}...`;

    const relativePath = path.relative(process.cwd(), file);

    const originContent = await fs.readFile(relativePath, "utf8");
    const images = findImagesInMarkdown(originContent);
    if (images.size > 0) {
      results.set(relativePath, images);
    }

    spinner.start();
  }

  spinner.stop();

  for (const [file, images] of results) {
    console.log(`\n${file}`);
    for (const image of images) {
      console.log(`  ${image}`);
    }
  }
}

await main();

The result shows:

../translated-content/files/es/web/api/web_components/index.md
  https://pbs.twimg.com/media/EOW1l5dVAAADJuF?format=jpg&name=large

../translated-content/files/es/web/api/window/open/index.md
  menusystemcommands.png?size=webview

../translated-content/files/es/web/css/transform-function/index.md
  transform_functions_generic_transformation_cart.png?size=webview
  transform_functions_transform_composition_cart.png?size=webview

../translated-content/files/es/web/html/content_categories/index.md
  content_categories_venn.png?size=webview

../translated-content/files/es/web/html/element/input/index.md
  mozactionhint.png?size=webview

../translated-content/files/pt-br/conflicting/web/javascript/inheritance_and_the_prototype_chain/index.md
  =figure8.3.png

../translated-content/files/ru/learn/javascript/building_blocks/image_gallery/index.md
  https://github.com/ConstantineZz/javaScript/blob/master/gallery.png?raw=true

../translated-content/files/zh-tw/web/api/battery_status_api/index.md
  http://x.co/qr/batstat?s=165

Only the =figure8.3.png in files/pt-br/conflicting/web/javascript/inheritance_and_the_prototype_chain/index.md has the prefix =, while the file stored in this repo does have the = prefix, so the replacement is not necessary and safe to be removed.

---

How did you test this change?

No additional test.

[caugner]

I don't think we need to support the other case either, as mdn.mozillademos.org has been decommissioned. Or do we still have links to /files?

Suggested change

	const absoluteURL = /^\/files\/\d+/.test(src)
	? new URL(`https://mdn.mozillademos.org${src}`)
	: new URL(src, baseURL);
	const absoluteURL = new URL(src, baseURL);

[yin1999]

Yes, we still have. Here is a link (not the only one):

• https://github.com/mdn/translated-content/blob/db4ed37005d459ca3f1c71d0f3916fb069c7fa82/files/es/learn/forms/how_to_build_custom_form_controls/index.md?plain=1#L20

[caugner]

@fiji-flo Will rari support this? (I guess not, which means we should migrate those in translated-content.)