Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(seo): identify sponsored links #11217

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 30, 2024

Summary

(MP-1161)

Problem

We don't identify our placement links as sponsored, but Google recommends this.

Solution

Update the rel attribute of those links to include sponsored.


Screenshots

(No visible change.)


How did you test this change?

Trivial change, not explicitly tested.

@caugner caugner requested a review from a team as a code owner May 30, 2024 15:09
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's a feature not a fix :)

@caugner caugner changed the title fix(placement): identify sponsored links fix(seo): identify sponsored links May 30, 2024
@caugner
Copy link
Contributor Author

caugner commented May 30, 2024

I'd say it's a feature not a fix :)

I guess you could say it's a feat(placement) or a fix(seo) (hopefully), but overall I don't think it's that big of a change to warrant feat:.

@caugner caugner merged commit 5d47456 into main May 30, 2024
14 checks passed
@caugner caugner deleted the MP-1161-identify-sponsored-links branch May 30, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants