Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog): hydration errors due to newsletter component #11106

Merged
merged 1 commit into from
May 13, 2024

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented May 10, 2024

Summary

Problem

Hydration errors on blog when logged in:

Uncaught Error: Minified React error #418; visit https://reactjs.org/docs/error-decoder.html?invariant=418 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    React 6
    x scheduler.production.min.js:13
    T scheduler.production.min.js:14
    3498 scheduler.production.min.js:14
    Webpack 12
2 react-dom.production.min.js:131:158
Uncaught Error: Minified React error #423; visit https://reactjs.org/docs/error-decoder.html?invariant=423 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    React 6
    x scheduler.production.min.js:13
    T scheduler.production.min.js:14
    3498 scheduler.production.min.js:14
    Webpack 12
react-dom.production.min.js:292:38

Solution

Ensure the form isn't rendered differently on initial hydration on the client when logged in.


How did you test this change?

  • Checkout main
  • yarn dev
  • yarn build:blog
  • start rumba, log in on localhost:5042
  • open blog
  • see hydration error
  • checkout PR branch
  • yarn dev
  • yarn build:blog
  • open blog on localhost:5042
  • see no hydration error

@LeoMcA LeoMcA requested a review from a team as a code owner May 10, 2024 15:47
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fiji-flo fiji-flo merged commit 36c3d0c into main May 13, 2024
14 checks passed
@fiji-flo fiji-flo deleted the fix-blog-hydration-errors branch May 13, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants