Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(baseline): checkmarks weren't reflecting mobile status #11002

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Apr 25, 2024

Summary

Fixes #10997

Problem

We weren't taking mobile statuses into account when working out whether to display a checkmark next to a browser. For Safari we were only checking the safari key, we weren't also checking the safari_ios key, for instance.

Solution

Check both desktop and mobile keys for Chrome, Firefox and Safari.


Screenshots

Before

image

After

image


How did you test this change?

  • yarn dev
  • Visited http://localhost:3000/en-US/docs/Web/API/Fullscreen_API and a few other pages to verify checks/crosses worked as expected
  • Looked at generated source to ensure titles and aria-lables were still being generated correctly, with no "[object Object]" strings within

@LeoMcA LeoMcA requested a review from a team as a code owner April 25, 2024 11:20
@LeoMcA LeoMcA merged commit 242c2f8 into main Apr 25, 2024
14 checks passed
@LeoMcA LeoMcA deleted the baseline-fix-mobile-status branch April 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline status banner checkmarks are incorrect when there's a difference between desktop and mobile support
2 participants