enhance(macros/CSSInfo): add "Animation type" link #10947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
requested changes
Apr 18, 2024
caugner
changed the title
mostafaroshdy1
force-pushed
the
add-hyperlink
branch
from
448f3d5
to
978793a
Compare
caugner
requested changes
Apr 19, 2024
caugner
changed the title
caugner
approved these changes
Apr 19, 2024
…on document (mdn#10946) fix(playground): dispatch readystatechange event fix(playground): dispatch DOMContentLoaded event on document + bubble
Problem: We identified a drop in search engine impressions in April 2023, which coincides with the Web/API retitle project (mdn/mdn#284), and we cannot rule out that there is a causal relationship. Solution: Run an experiment with 500 randomly sampled Web/API pages (of 2719 affected), partially reverting the change to their `<title>` (but not to the `<h1>`) by essentially replacing `Foo: bar property` with `Foo.bar property`.
The previous test group was not sampled from the full population of affected Web/API pages.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
mostafaroshdy1
force-pushed
the
add-hyperlink
branch
from
22e521c
to
bf0dd4d
Compare
github-actions
bot
added
dependencies
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
|
I have updated the commits signature , i have followed these steps |
caugner
requested changes
Apr 19, 2024
caugner
reviewed
Apr 19, 2024
caugner
approved these changes
Apr 19, 2024
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR added the enchantment in this issue #8721
Problem
The ''Animation type" string was not a hyperlink, so i made it an anchor tag referring to the related page
Solution
Screenshots
Before
After
How did you test this change?
Locally using
yarn dev