Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct scroll-timeline-axis and mask-repeat initial value #622

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

ludofischer
Copy link
Contributor

@ludofischer ludofischer commented Oct 27, 2022

  1. The current scroll-animations spec says the initial value is 'block'. https://w3c.github.io/csswg-drafts/scroll-animations/#scroll-timeline-axis. none does not look like a legal value to me.
  2. The mask-repeat initial value is repeat: https://drafts.fxtf.org/css-masking/#the-mask-repeat
    You can even check that on the MDN page that says the initial value is no-repeat by setting mask-repeat to initial.

The current spec says the initial value is
'block'.
According to the spec, the correct initial value should be 'repeat'.
@ludofischer ludofischer changed the title fix: correct scroll-timeline-axis initial value fix: correct scroll-timeline-axis and mask-repeat initial value Oct 27, 2022
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @ludofischer ! Wish we could get on with populating these directly from the specifications.

@wbamberg wbamberg merged commit e48302d into mdn:main Oct 28, 2022
@ludofischer ludofischer deleted the fix-timeline-axis branch October 28, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants