-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG element pages that start with "mesh" are missing #987
Comments
@eatmorepies-dev I don't believe those document pages have ever existed. cc @chrisdavidmills @peterbe Shouldn't we have detected these as broken links in Yari's local server? |
Yup, the pages for We could remove the links for now, but personally I'd rather keep them and update the styling of "dead" internal links to some kind of red color like we used to have them, maybe with some kind of readout at the bottom of the page to say that these pages don't exist, please consider contributing, or something similar to that. I'd rather not do titles/tooltips again , as we made a decision to move away from those for accessibility's sake. |
Huh. Weird. Yeah, it should have noticed that as a flaw but it didn't. Strange. What should ultimately happen is that instead of: <a href="/en-US/docs/Web/SVG/Element/mesh"><code><mesh></code></a> it should become something like: <a class="new" title="This page does not exist yet. Consider contributing"><code><mesh></code></a> But first of all, it's a regular link (once KS is done making the HTML) and the flaw |
Ah!! This is interesting. The What's cool about flaws is that they're very visual. You can console.log them or see them in localhost:3000 on the toolbar or list them in the Flaws Dashboard. But one thing we could do in
Thoughts and ideas? |
To make this actionable, I think the KS macro that produces these links should get the first improvement. I.e. instead of just:
it should instead be expanded to something like:
|
Related to https://github.com/mdn/mdn-minimalist/issues/443 From an accessibility point of view:
My suggestion would be to add an endnote (perhaps using dagger as anchor text?) and explain there, that this page does not exist. @chrisdavidmills Have you created issues to ask for writing of those articles? (There was something editorial steeting commitee you mentioned in #1506 (comment)) |
@eatmorepies-dev Thanks for catching this! |
If the page is |
I read @chrisdavidmills in a way, that they should not be removed, but marked up as broken instead. (Likely also relevant for #1510) |
https://developer.mozilla.org/en-US/docs/Web/CSS/:link This Is a minimalist issue anyway. |
Yeah, our solution for all these |
Filled mdn/yari#2705 |
There are no longer any |
Summary
Found while viewing https://developer.mozilla.org/en-US/docs/Web/SVG/Element. All of the links to elements that start with "mesh" return 404 errors.
Steps To Reproduce (STR)
How can we reproduce the problem?
Actual behavior
The page corresponding to those particular SVG elements are missing.
Expected behavior
Display the relevant documentation.
Additional context
Is there anything else we should know?
*Standard angle bracket formatting removed due to GitHub restrictions.
The text was updated successfully, but these errors were encountered: