Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI] Add abort reason to AbortSignal #11593

Closed
6 of 7 tasks
Rumyra opened this issue Dec 30, 2021 · 1 comment
Closed
6 of 7 tasks

[WebAPI] Add abort reason to AbortSignal #11593

Rumyra opened this issue Dec 30, 2021 · 1 comment
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Dec 30, 2021

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
    or
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

https://bugzilla.mozilla.org/show_bug.cgi?id=1737771

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 30, 2021
@Rumyra Rumyra removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 30, 2021
@hamishwillee hamishwillee self-assigned this Jan 3, 2022
@hamishwillee
Copy link
Collaborator

hamishwillee commented Jan 4, 2022

Status - pretty much done

As part of this need to do https://bugzilla.mozilla.org/show_bug.cgi?id=1745372

Generally we need a new Using AbortController doc, but I consider that out of scope for this. Essentially right now we have one example that shows how to use it with fetch, and a bunch of little fragment examples showing just how to access bits of data. That is fine, because aborting Fetch is still the main use case.

However this is being used more widely. Further, it is reasonable for people to use this in their own APIs and in both browser and node/deno environments. As it is now, we don't explain how you would write your own code that uses controllers and exposes them for others to use. This would be a good starting point https://developers.google.com/web/updates/2017/09/abortable-fetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
Archived in project
Development

No branches or pull requests

3 participants