Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes incorrectly claimed to be added in Chrome 43 #7843

Closed
foolip opened this issue Dec 14, 2020 · 5 comments
Closed

Attributes incorrectly claimed to be added in Chrome 43 #7843

foolip opened this issue Dec 14, 2020 · 5 comments
Assignees
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API idle 🐌 Issues and pull requests with no recent activity

Comments

@foolip
Copy link
Collaborator

foolip commented Dec 14, 2020

Chrome 43 fixed its bindings so that Web IDL attributes appear on the prototypes:
https://developers.google.com/web/updates/2015/04/DOM-attributes-now-on-the-prototype-chain

Because of this, tests like 'attributeName' in InterfaceName can be misleading, suggesting that something was added in Chrome 43. This has come up a lot in @vinyldarkscratch's and my work on https://github.com/foolip/mdn-bcd-collector.

Not all cases of this have been caught in review, and npm run traverse chrome api 43 lists a lot of features. Some of these were introduced earlier, for example api.HTMLMediaElement.volume is much older.

We need to go through any attributes claimed to be added in Chrome 43 and check if they were really available earlier.

@foolip
Copy link
Collaborator Author

foolip commented Dec 14, 2020

#7755 is similar, but for Chrome 44.

@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 14, 2020
@foolip
Copy link
Collaborator Author

foolip commented Dec 17, 2020

While reviewing #7990 I spotted some that I'm almost certain are incorrect and need fixing as part of this issue, namely api.HTMLMediaElement.*. Those are all very old APIs, not introduced in Chrome 43.

@ddbeck
Copy link
Collaborator

ddbeck commented Jun 21, 2021

@foolip What's the trick to testing that attributes are supported before 43? Testing on actual instances, instead of the prototype?

@foolip
Copy link
Collaborator Author

foolip commented Jun 21, 2021

@ddbeck exactly, an instance is needed, and that's what collector fixes like foolip/mdn-bcd-collector#1247 ends up doing.

@queengooborg
Copy link
Collaborator

I think that we've pretty much fixed this, and any additional instances should be catchable by the collector. I'm going to close this issue and consider it to be a part of the bigger collector synchronization goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API idle 🐌 Issues and pull requests with no recent activity
Projects
None yet
Development

No branches or pull requests

3 participants