Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittests to all linter files #15912

Closed
queengooborg opened this issue Apr 20, 2022 · 3 comments
Closed

Add unittests to all linter files #15912

queengooborg opened this issue Apr 20, 2022 · 3 comments
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@queengooborg
Copy link
Contributor

It would be great to add Mocha unittests to our linters to ensure they're working as expected. Perhaps after the planned linter rework though?
@queengooborg queengooborg added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Apr 20, 2022
@bershanskiy
Copy link
Contributor

I'm interested in this issue. What kind of "linter rework" do you have in mind?

@queengooborg
Copy link
Contributor Author

The linter rework was a wonderful idea Daniel was working on before his departure from Mozilla. His idea was to transform the individual linters into a more modular style, allowing each linter to select a scope as needed (file, feature, browser, etc.). Check out openwebdocs/project#79 for more details on that!

@queengooborg
Copy link
Contributor Author

Closing this issue in favor of openwebdocs/project#162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@queengooborg @bershanskiy