Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection closed #67

Closed
097115 opened this issue Oct 19, 2020 · 4 comments · Fixed by #68
Closed

Connection closed #67

097115 opened this issue Oct 19, 2020 · 4 comments · Fixed by #68
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@097115
Copy link

097115 commented Oct 19, 2020

Describe the bug

Exits with connection closed after some inactivity

To Reproduce

  1. Launch kirc, connect so some server, join some channel
  2. Make the prompt appear by e.g. pressing the Up arrow
  3. Do nothing for some 10 minutes (5 is not enough, really :)
  4. Press Enter (or you can type any command here, like /time), observe kirc quitting with connection closed instead of just getting an expected reply from a server,No text to send

Desktop (please complete the following information):

  • Linux, macOS
  • kirc-0.1.6 (5c6c123)
  • Tested both with undernet.org and freenode.net, both secure and insecure connections.
@mcpcpc
Copy link
Owner

mcpcpc commented Oct 19, 2020

This is the current expected functionality of kirc since user input is a blocking function. This means server message handling (i.e. automatic keep-alive/PING response or new received messages) cannot be performed while in "user input mode" until the user presses Enter/Return. Ultimately, the server connection times out and closes.

Consequently, I am working to implement an asynchronous version of the input handling function (see issue #66) which should address this "adverse behavior" going forward.

I will leave this open until #66 is resolved.

@mcpcpc mcpcpc self-assigned this Oct 19, 2020
@097115
Copy link
Author

097115 commented Oct 19, 2020

Thanks for the explanation, looking forward!

@mcpcpc mcpcpc linked a pull request Oct 20, 2020 that will close this issue
@mcpcpc
Copy link
Owner

mcpcpc commented Oct 20, 2020

@097115 : 0.1.7 (via #68) is ready to be merged. Would you be able to test this branch to make sure that it addresses your concern?

@mcpcpc mcpcpc added bug Something isn't working enhancement New feature or request labels Oct 20, 2020
@097115
Copy link
Author

097115 commented Oct 20, 2020

@mcpcpc Seems to be working fine, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants