Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kirc requires a proper text editor #53

Closed
1 of 4 tasks
mcpcpc opened this issue Oct 5, 2020 · 0 comments · Fixed by #54
Closed
1 of 4 tasks

kirc requires a proper text editor #53

mcpcpc opened this issue Oct 5, 2020 · 0 comments · Fixed by #54
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mcpcpc
Copy link
Owner

mcpcpc commented Oct 5, 2020

Using fgets() to read user input from the stdin buffer is a fragile solution that required proper handling on the VTE-end. This impacts the portability as implementation of terminfo flags varies and is not guaranteed. Going forward, we need a solution that has fewer dependencies on the actual VTE.

Considerations...

  • Do nothing. Set VTE flags via escape command sequences. Reduces portability as user experience may vary from terminal emulator to terminal emulator.
  • Restrict input char length. This probably the easiest solution, but really hinders the project and user experience.
  • Create a custom text editor. This will quickly increase the size of kirc and adds unwanted complexity.
  • Bring your own editor (BYOE)! This probably my favorite concept but possibly adds significant complexity to how kirc interacts with external editors.
@mcpcpc mcpcpc added enhancement New feature or request help wanted Extra attention is needed labels Oct 5, 2020
@mcpcpc mcpcpc self-assigned this Oct 5, 2020
@mcpcpc mcpcpc changed the title kirc requires a PROPER text editor kirc requires a proper text editor Oct 5, 2020
@mcpcpc mcpcpc linked a pull request Oct 7, 2020 that will close this issue
@mcpcpc mcpcpc closed this as completed in #54 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant