Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text wrapping bug #117

Closed
mcpcpc opened this issue Jul 14, 2021 · 5 comments · Fixed by #118 or #119
Closed

text wrapping bug #117

mcpcpc opened this issue Jul 14, 2021 · 5 comments · Fixed by #118 or #119
Assignees
Labels
bug Something isn't working

Comments

@mcpcpc
Copy link
Owner

mcpcpc commented Jul 14, 2021

as reported on #kisslinux by @kyxor:

you do guys ever get a bug in kirc when you reach the end of terminal window size, the text starts to wrap to new lines and displays corrupted symbols. doesn't always happen, probably depends on the last character

https://0x0.st/-O3g.png

@mcpcpc mcpcpc added the bug Something isn't working label Jul 14, 2021
@mcpcpc mcpcpc self-assigned this Jul 14, 2021
@kyx0r
Copy link

kyx0r commented Jul 15, 2021

@mcpcpc just in case you don't see on irc, I fixed it - https://0x0.st/-Odx.patch

It may not be final cause I have to test it good, but it works.

@kyx0r
Copy link

kyx0r commented Jul 15, 2021

@mcpcpc Sorry, I didn't test the utf-8 properly, but I fix.

Try this patch now: https://0x0.st/-Odn.patch

@mcpcpc mcpcpc mentioned this issue Jul 16, 2021
@mcpcpc
Copy link
Owner Author

mcpcpc commented Jul 16, 2021

thanks!

@kyx0r
Copy link

kyx0r commented Jul 16, 2021

@mcpcpc mcpcpc_: you applied the wrong patch :( I am sorry first version has messed up utf-8 chars, please reapply this one: https://0x0.st/-Odn.patch

The difference is in "txtlenb += u8Next(buf+txtlenb, 0);" has to have +txtlenb because we want to iterate over the chars, in the first patch it does not

@mcpcpc mcpcpc linked a pull request Jul 16, 2021 that will close this issue
@mcpcpc
Copy link
Owner Author

mcpcpc commented Jul 16, 2021

Errr my bad. Fixed! Thanks again =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants