Handle NaN #75

valichek · 2018-09-17T08:42:40Z

Fixes: #74.

mcollina · 2018-09-17T08:44:11Z

test/15-elements-maps.js

+  var toEncode = { a: NaN, hello: 'world' }
+  var buf = instance.encode(toEncode)
+
+  t.deepEqual(expected, instance.decode(buf), 'must ignore NaN')


why? Shouldn't it have the same behavior as encoded directly?

did it same as for undefined value

They are different. The behavior of undefined is matching how JSON.stringify() works. undefined in javascript means "there is nothing here". NaN has a different meaning altogether. It should throw anyway.

Ok, will remove that

mcollina

LGTM

Handle NaN

1aae9d2

mcollina reviewed Sep 17, 2018

View reviewed changes

Throw error when map contains NaN

b72d3c1

mcollina approved these changes Sep 17, 2018

View reviewed changes

mcollina merged commit 2b96cd2 into mcollina:master Sep 17, 2018

ninevra mentioned this pull request Feb 11, 2021

msgpack5 throws when encoding NaN, contrary to spec #93

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle NaN #75

Handle NaN #75

valichek commented Sep 17, 2018 •

edited by mcollina

Loading

mcollina Sep 17, 2018

valichek Sep 17, 2018

mcollina Sep 17, 2018

valichek Sep 17, 2018

mcollina left a comment

Handle NaN #75

Handle NaN #75

Conversation

valichek commented Sep 17, 2018 • edited by mcollina Loading

mcollina Sep 17, 2018

Choose a reason for hiding this comment

valichek Sep 17, 2018

Choose a reason for hiding this comment

mcollina Sep 17, 2018

Choose a reason for hiding this comment

valichek Sep 17, 2018

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

valichek commented Sep 17, 2018 •

edited by mcollina

Loading