Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blade error notification from Blade to Vue #70

Closed
mchekin opened this issue Sep 13, 2020 · 2 comments
Closed

Blade error notification from Blade to Vue #70

mchekin opened this issue Sep 13, 2020 · 2 comments
Assignees
@mchekin
Labels
vue

Comments

@mchekin
Copy link
Owner

mchekin commented Sep 13, 2020

Currently only synchronous request errors are reported inside a Blade template.
https://github.com/mchekin/rpg/blob/master/resources/views/partials/errors.blade.php#L5

But the Vue components, which use Axios for asynchronous API calls, do not report notify the end-user in case of API call failure.
https://github.com/mchekin/rpg/blob/master/resources/js/components/StoreManagement.vue#L320

We need:

  • existing Vue component raising an error events
  • a Vue component for error notifications, instead of Blade, that handles both synchronous and Vue component error event display.
@mchekin mchekin self-assigned this Feb 6, 2021
@mchekin
Copy link
Owner Author

mchekin commented Feb 6, 2021 •
edited
Loading

Working on it as part of https://github.com/mchekin/rpg/tree/buying-from-character-store

@mchekin
Copy link
Owner Author

mchekin commented Mar 30, 2021

Resolved in #74

@mchekin mchekin closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchekin mchekin

Labels
vue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mchekin