Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function code response error handling needs improvement #16

Open
KaneTW opened this issue Aug 28, 2021 · 3 comments
Open

Function code response error handling needs improvement #16

KaneTW opened this issue Aug 28, 2021 · 3 comments
Labels
enhancement / new feature help wanted

Comments

@KaneTW
Copy link

KaneTW commented Aug 28, 2021

Not all function responses can currently be handled. For example, I have a device that outputs FC code 0x2 (RR, resource error) after two weeks of operation. Pyprofibus doesn't notice and just outputs a datagram with empty data.
@mbuesch
Copy link
Owner

mbuesch commented Aug 28, 2021

Thanks for your message.

Are you able to implement such error handling? If so, please feel free to submit a pull request with your suggested implementation.

@KaneTW
Copy link
Author

KaneTW commented Aug 28, 2021

I'll submit a PR once I have an implementation.

@mbuesch
Copy link
Owner

mbuesch commented Aug 28, 2021

Your help is much appreciated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement / new feature help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbuesch @KaneTW