From 05d9535cdb92faa55cc6a5eff550abc9c24a67e4 Mon Sep 17 00:00:00 2001 From: saseungmin Date: Sat, 28 Oct 2023 22:18:06 +0900 Subject: [PATCH 1/6] =?UTF-8?q?fix(@nf-team/react):=20useThrottleCallback?= =?UTF-8?q?=20dependencyList=20=EC=B6=94=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/react/src/hooks/useThrottleCallback.test.ts | 2 +- packages/react/src/hooks/useThrottleCallback.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/react/src/hooks/useThrottleCallback.test.ts b/packages/react/src/hooks/useThrottleCallback.test.ts index 4222db2..ba9bea2 100644 --- a/packages/react/src/hooks/useThrottleCallback.test.ts +++ b/packages/react/src/hooks/useThrottleCallback.test.ts @@ -15,7 +15,7 @@ describe('useThrottleCallback', () => { jest.clearAllTimers(); }); - const useThrottleCallbackHook = () => renderHook(() => useThrottleCallback(callback, delay)); + const useThrottleCallbackHook = () => renderHook(() => useThrottleCallback(callback, delay, [])); context('delay 시간이 되지 않은 경우', () => { it('callback 함수가 호출되지 않아야만 한다', async () => { diff --git a/packages/react/src/hooks/useThrottleCallback.ts b/packages/react/src/hooks/useThrottleCallback.ts index 6d40909..0cdba10 100644 --- a/packages/react/src/hooks/useThrottleCallback.ts +++ b/packages/react/src/hooks/useThrottleCallback.ts @@ -3,6 +3,7 @@ import { useCallback, useRef } from 'react'; function useThrottleCallback( callback: (...args: U) => void, delay: number, + dependencyList: any[], ) { const timer = useRef | null>(null); @@ -13,7 +14,7 @@ function useThrottleCallback( timer.current = null; }, delay); } - }, [callback, delay]); + }, [...dependencyList, delay]); return throttledCallback; } From 3e0e8abf7bdceddd33322e46b5d05a4ea5bbf99f Mon Sep 17 00:00:00 2001 From: saseungmin Date: Sat, 28 Oct 2023 22:19:31 +0900 Subject: [PATCH 2/6] docs: @nf-team/react changeset --- .changeset/early-guests-peel.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/early-guests-peel.md diff --git a/.changeset/early-guests-peel.md b/.changeset/early-guests-peel.md new file mode 100644 index 0000000..d5b866a --- /dev/null +++ b/.changeset/early-guests-peel.md @@ -0,0 +1,5 @@ +--- +"@nf-team/react": patch +--- + +fix(@nf-team/react): useThrottleCallback dependencyList 추가 From 8d9180306e38b50fb3470fac8fd9b856b25528af Mon Sep 17 00:00:00 2001 From: saseungmin Date: Sat, 28 Oct 2023 22:23:03 +0900 Subject: [PATCH 3/6] =?UTF-8?q?refactor(useThrottleCallback):=20=ED=8C=8C?= =?UTF-8?q?=EB=9D=BC=EB=AF=B8=ED=84=B0=20=EC=88=9C=EC=84=9C=20=EC=88=98?= =?UTF-8?q?=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/react/src/hooks/useThrottleCallback.test.ts | 2 +- packages/react/src/hooks/useThrottleCallback.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/hooks/useThrottleCallback.test.ts b/packages/react/src/hooks/useThrottleCallback.test.ts index ba9bea2..4dac85d 100644 --- a/packages/react/src/hooks/useThrottleCallback.test.ts +++ b/packages/react/src/hooks/useThrottleCallback.test.ts @@ -15,7 +15,7 @@ describe('useThrottleCallback', () => { jest.clearAllTimers(); }); - const useThrottleCallbackHook = () => renderHook(() => useThrottleCallback(callback, delay, [])); + const useThrottleCallbackHook = () => renderHook(() => useThrottleCallback(callback, [], delay)); context('delay 시간이 되지 않은 경우', () => { it('callback 함수가 호출되지 않아야만 한다', async () => { diff --git a/packages/react/src/hooks/useThrottleCallback.ts b/packages/react/src/hooks/useThrottleCallback.ts index 0cdba10..64848e8 100644 --- a/packages/react/src/hooks/useThrottleCallback.ts +++ b/packages/react/src/hooks/useThrottleCallback.ts @@ -2,8 +2,8 @@ import { useCallback, useRef } from 'react'; function useThrottleCallback( callback: (...args: U) => void, - delay: number, dependencyList: any[], + delay: number, ) { const timer = useRef | null>(null); From 7e95320abb2d7ae5bd80db4d96e63a2de9154b1c Mon Sep 17 00:00:00 2001 From: saseungmin Date: Sat, 28 Oct 2023 22:24:48 +0900 Subject: [PATCH 4/6] docs: update changeset --- .changeset/early-guests-peel.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.changeset/early-guests-peel.md b/.changeset/early-guests-peel.md index d5b866a..a591f6e 100644 --- a/.changeset/early-guests-peel.md +++ b/.changeset/early-guests-peel.md @@ -2,4 +2,5 @@ "@nf-team/react": patch --- -fix(@nf-team/react): useThrottleCallback dependencyList 추가 +- fix(@nf-team/react): useThrottleCallback dependencyList 추가 +- refactor(useThrottleCallback): 파라미터 순서 수정 From a053400cea72a794e54b2f1df163908daf740a5c Mon Sep 17 00:00:00 2001 From: saseungmin Date: Sat, 28 Oct 2023 22:34:18 +0900 Subject: [PATCH 5/6] =?UTF-8?q?fix(useLessThenScrollY):=20=ED=85=8C?= =?UTF-8?q?=EC=8A=A4=ED=8A=B8=20=EA=B9=A8=EC=A7=80=EB=8A=94=20=EC=9D=B4?= =?UTF-8?q?=EC=8A=88=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/react/src/hooks/useLessThenScrollY.ts | 2 +- packages/react/src/hooks/useThrottleCallback.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react/src/hooks/useLessThenScrollY.ts b/packages/react/src/hooks/useLessThenScrollY.ts index f00156e..52b94d5 100644 --- a/packages/react/src/hooks/useLessThenScrollY.ts +++ b/packages/react/src/hooks/useLessThenScrollY.ts @@ -10,7 +10,7 @@ function useLessThenScrollY(targetScrollY = 0, delay = 200): boolean { [targetScrollY], ); - const throttledCallback = useThrottleCallback(handleScrollAction, delay); + const throttledCallback = useThrottleCallback(handleScrollAction, [], delay); useEffect(() => { window.addEventListener('scroll', throttledCallback); diff --git a/packages/react/src/hooks/useThrottleCallback.ts b/packages/react/src/hooks/useThrottleCallback.ts index 64848e8..61cec32 100644 --- a/packages/react/src/hooks/useThrottleCallback.ts +++ b/packages/react/src/hooks/useThrottleCallback.ts @@ -1,8 +1,8 @@ -import { useCallback, useRef } from 'react'; +import { DependencyList, useCallback, useRef } from 'react'; function useThrottleCallback( callback: (...args: U) => void, - dependencyList: any[], + dependencyList: DependencyList[], delay: number, ) { const timer = useRef | null>(null); From dbf36691f04f625d3be8fb6f718a27e20c9b7a3c Mon Sep 17 00:00:00 2001 From: saseungmin Date: Sat, 28 Oct 2023 22:34:54 +0900 Subject: [PATCH 6/6] docs: update changeset --- .changeset/early-guests-peel.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.changeset/early-guests-peel.md b/.changeset/early-guests-peel.md index a591f6e..ce68ce1 100644 --- a/.changeset/early-guests-peel.md +++ b/.changeset/early-guests-peel.md @@ -4,3 +4,4 @@ - fix(@nf-team/react): useThrottleCallback dependencyList 추가 - refactor(useThrottleCallback): 파라미터 순서 수정 +- fix(useLessThenScrollY): useThrottleCallback 사용중인 곳 파라미터 수정