From 50be0f97f0701aafb031b12cce4d68003c71c9da Mon Sep 17 00:00:00 2001
From: Masha Basmanova <mbasmanova@fb.com>
Date: Thu, 30 Nov 2023 12:26:47 -0800
Subject: [PATCH] Log number of failed runs in ExpressionFuzzer (#7809)

Summary:
Log total and failed iterations at the end of the run. This allows use to see
cases where random inputs generated by the Fuzzer are not able to test a
function because these are rejected early on.

```
velox_expression_fuzzer_test --logtostderr --only from_base64

Total iterations: 10
Total failed: 8
```

Pull Request resolved: https://github.com/facebookincubator/velox/pull/7809

Reviewed By: xiaoxmeng

Differential Revision: D51716747

Pulled By: mbasmanova

fbshipit-source-id: 5c661a02d515e65594cec329a27e657f438ee802
---
 velox/expression/tests/ExpressionFuzzer.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/velox/expression/tests/ExpressionFuzzer.cpp b/velox/expression/tests/ExpressionFuzzer.cpp
index 54f8cd510bae..74fa75cf1472 100644
--- a/velox/expression/tests/ExpressionFuzzer.cpp
+++ b/velox/expression/tests/ExpressionFuzzer.cpp
@@ -1308,6 +1308,7 @@ void ExpressionFuzzer::go() {
 
   auto startTime = std::chrono::system_clock::now();
   size_t i = 0;
+  size_t numFailed = 0;
 
   while (!isDone(i, startTime)) {
     LOG(INFO) << "==============================> Started iteration " << i
@@ -1346,6 +1347,10 @@ void ExpressionFuzzer::go() {
       throw;
     }
 
+    if (result.exceptionPtr) {
+      ++numFailed;
+    }
+
     // If both paths threw compatible exceptions, we add a try() function to
     // the expression's root and execute it again. This time the expression
     // cannot throw.
@@ -1360,6 +1365,9 @@ void ExpressionFuzzer::go() {
     ++i;
   }
   logStats();
+
+  LOG(ERROR) << "Total iterations: " << i;
+  LOG(ERROR) << "Total failed: " << numFailed;
 }
 
 void expressionFuzzer(FunctionSignatureMap signatureMap, size_t seed) {