Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internals to work with log time intervals #72

Closed
9 tasks
dbrakenhoff opened this issue Oct 28, 2024 · 1 comment
Closed
9 tasks

Refactor internals to work with log time intervals #72

dbrakenhoff opened this issue Oct 28, 2024 · 1 comment
Assignees

Comments

@dbrakenhoff
Copy link
Collaborator

dbrakenhoff commented Oct 28, 2024

Currently TTim works by computing solutions for all log time intervals, which is nice when you want to compute the heads at some point for a period of time, but is inefficient for everything else (i.e. contouring heads at a specific time).

This issue is for keeping track of changes that need to be done to the code to change TTims default behavior to compute solutions per log time interval.

  • convert all internal arrays with npval dimension to a dictionary with log time intervals t_int as keys and modify array dim npval to nppar
    • in TtimModel
    • in AquiferData
    • in Element and all subclasses
  • Add solve_interval()
  • Add initialize_interval() to Model, Aquifer, Element and all subclasses. One challenge here is to avoid running duplicate code with inheritance WellBase and Well both have intialize() and initialize_interval()
  • Add t_int to all Equations.
  • check out whether lababs is computed correctly
  • figure out how to efficiently compute head/potential/etc. for multiple times.

Start by showing working example for a single Well, so we can discuss/improve implementation. See PR #74 for first implementation.

@dbrakenhoff dbrakenhoff self-assigned this Oct 29, 2024
@dbrakenhoff dbrakenhoff linked a pull request Nov 7, 2024 that will close this issue
@dbrakenhoff
Copy link
Collaborator Author

Won't implement. Closing this issue. See #74 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant