From 9b6ba96c463ce671475a3192c0c41e6dfa3ccefc Mon Sep 17 00:00:00 2001 From: Mayya Sharipova Date: Fri, 28 Jul 2023 09:08:26 -0400 Subject: [PATCH] Fix occasional failure in BaseKnnVectorsFormatTestCase#testIllegalDimensionTooLarge Depending whether a document with dimensions > maxDims created on a new segment or already existing segment, we may get different error messages. This fix adds another possible error message we may get. Relates to #12436 --- .../lucene/tests/index/BaseKnnVectorsFormatTestCase.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java index 3cf5944fd921..ec77299e2b6e 100644 --- a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java +++ b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java @@ -501,7 +501,10 @@ public void testIllegalDimensionTooLarge() throws Exception { exc = expectThrows(IllegalArgumentException.class, () -> w.addDocument(doc3)); assertTrue( exc.getMessage() - .contains("Inconsistency of field data structures across documents for field [f]")); + .contains("Inconsistency of field data structures across documents for field [f]") + || exc.getMessage() + .contains( + "vector's dimensions must be <= [" + getVectorsMaxDimensions("f") + "]")); w.flush(); Document doc4 = new Document();