Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Line numbers 1px gap and flicker on collapse if highlighted for devices with high DPI screens #18

Open
mayurankv opened this issue Jul 8, 2023 · 2 comments
Assignees
Labels
bug Something isn't working reading mode Relevant to Obsidian reading mode upstream Upstream issue

Comments

@mayurankv
Copy link
Owner

Describe the bug

Line numbers 1px gap and flicker on collapse if highlighted for devices with high DPI screens

Steps to reproduce

Highlight multiple lines in a codeblock in reading mode

```test hl:2-4
line 1
line 2
line 3
line 4
line 5
```

Expected behaviour

There should be no gaps in the highlights or flickering in highlights when collapsing.

Current behaviour

There can be both gaps and flickering.

Environment

  • Plugin Version: 1.0.0
  • Obsidian Version: 1.3.5
  • Platform: Desktop
  • OS: macOS

Screenshots

Additional context

Upstream issue.
Due to a bug with position sticky css implementation - see this issue.

@mayurankv mayurankv added bug Something isn't working upstream Upstream issue labels Jul 8, 2023
@mayurankv mayurankv self-assigned this Jul 8, 2023
@mayurankv mayurankv added the reading mode Relevant to Obsidian reading mode label Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Sep 7, 2023
@mayurankv mayurankv removed the Stale label Oct 24, 2023
Copy link

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Dec 24, 2023
@mayurankv mayurankv removed the Stale label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reading mode Relevant to Obsidian reading mode upstream Upstream issue
Projects
None yet
Development

No branches or pull requests

1 participant