From 668b14f176ab688d1a28ff19e01b074a89461829 Mon Sep 17 00:00:00 2001
From: Steven Bal <steven@maykinmedia.nl>
Date: Thu, 19 Dec 2024 16:03:46 +0100
Subject: [PATCH] :construction_worker: [maykinmedia/open-api-framework#92]
 Make sure docs are built in CI

---
 .github/workflows/ci.yml | 12 +++++++++---
 docs/conf.py             |  2 +-
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 43ac673a..418127cc 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -12,9 +12,9 @@ on:
 
 env:
   IMAGE_NAME: maykinmedia/open-klant
-  DJANGO_SETTINGS_MODULE: openklant.conf.ci
-  DB_PASSWORD: ''
-  DB_USER: postgres
+  # DJANGO_SETTINGS_MODULE: openklant.conf.ci
+  # DB_PASSWORD: ''
+  # DB_USER: postgres
 
 jobs:
   # determine changed files to decide if certain jobs can be skipped or not
@@ -79,7 +79,10 @@ jobs:
           python src/manage.py collectstatic --noinput --link
           coverage run src/manage.py test src
         env:
+          DJANGO_SETTINGS_MODULE: objects.conf.ci
           SECRET_KEY: dummy
+          DB_USER: postgres
+          DB_PASSWORD: ''
 
       - name: Publish coverage report
         uses: codecov/codecov-action@v3
@@ -105,6 +108,8 @@ jobs:
               echo "Please update the environment documentation by running \`bin/generate_envvar_docs.sh\`"
               exit 1
           fi
+        env:
+          DJANGO_SETTINGS_MODULE: objects.conf.ci
 
   store-reusable-workflow-vars:
     name: create values which can be passed through a reusable workflow
@@ -123,6 +128,7 @@ jobs:
       - store-reusable-workflow-vars
     with:
       main-branch: 'master'
+      run-docs: true
       python-version: '3.11'
       docker-image-name: ${{ needs.store-reusable-workflow-vars.outputs.image-name }}
 
diff --git a/docs/conf.py b/docs/conf.py
index 73aa095a..b5417fbe 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -77,7 +77,7 @@
 # The theme to use for HTML and HTML Help pages.  See the documentation for
 # a list of builtin themes.
 #
-html_logo = "logo.svg"
+# html_logo = "logo.svg"
 html_theme = "sphinx_rtd_theme"
 
 # Add any paths that contain custom static files (such as style sheets) here,