Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

double increment in the disk check loop #2

Open
xmonader opened this issue Aug 14, 2023 · 1 comment
Open

double increment in the disk check loop #2

xmonader opened this issue Aug 14, 2023 · 1 comment

Comments

@xmonader
Copy link

xmonader commented Aug 14, 2023

image

not sure why is checked loop variable is incremented twice? and not sure how it affects the accuracy

@maxux
Copy link
Owner

maxux commented Aug 14, 2023

This repository is not maintained, it moved to threefoldtech organization.
This « bug » is not present on latest code update: threefoldtech#3
But this PR was not merged, I'll do review with @muhamadazmy to ensure I can merge it with no issue zos side.

Anyway, there are 128 loops, this double incrementation is indeed not supposed to be there but just reduce the tests to 64 loops, final result is the average. Amount of loops is just there to make average the more accurate possible, that mistake doesn't really make value less accurate :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants