Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to unmount collections and cleanup all local data #944

Closed
obedm503 opened this issue Sep 18, 2024 · 1 comment · Fixed by #981
Closed

Feature Request: Ability to unmount collections and cleanup all local data #944

obedm503 opened this issue Sep 18, 2024 · 1 comment · Fixed by #981

Comments

@obedm503
Copy link
Contributor

Right now neither the SyncManager, Collection, nor the PersistenceAdapter have a way of getting destroyed and cleaned up.

This means that when a user logs in to an application, uses it, and logs out, a malicious attacker could inspect the console and get access to all the cached information. PersistenceAdapters have no way to unregister and clean up after themselves and possibly confidential information remains on the system.

I am requesting a destroy method on the SyncManager and Collection classes to clean up after themselves and call the underlying persistence adapters' unregister method. Then, persistence adapters would implement their specific clean-up logic.

@psicomante
Copy link

psicomante commented Sep 23, 2024

I just saw this issue after creating #960. My issue is basically the same and I wrote some code to propose a solution. I didn't start yet using SyncManager, so i don't know if Max is going towards same direction or not, but I could do a PR in case my solution could be a nice idea to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants