Skip to content

Getting stuck on trying to request one game #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JourneyOver opened this issue Jun 22, 2022 · 3 comments · Fixed by #17
Closed

Getting stuck on trying to request one game #3

JourneyOver opened this issue Jun 22, 2022 · 3 comments · Fixed by #17
Assignees
@maxisoft
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@JourneyOver
Copy link

JourneyOver commented Jun 22, 2022 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

Just installed this after using ASFclaim for the longest time as I had been looking for something that just was a plugin instead for ASF instead of running a script.. Anyways not sure what is going on, it seems it started up just fine and it said it found 22 free games on reddit and started going through them but then it got to one and it just sits there and fails 5 times (Fail/Timeout) and stops until 30 minutes pass and then it tries to claim the same thing again but once again it just fails the 5 times (Fail/Timeout) and stops.

This seems to be the game/sub in particulur that it is failing on https://steamdb.info/sub/730490/

To Reproduce
Steps to reproduce the behavior:
Not really sure on how to reproduce as I already owned the sub/game that this is failing on, since I got it through when I had ASFclaim running.

Expected behavior
For it to see that it can't activate the product and move on.

Log ASF

2022-06-21 21:48:02|ArchiSteamFarm-516|INFO|ASF|InitCore() ArchiSteamFarm V5.2.7.5 (linux-arm/7f9b78e7-241a-4e0f-9246-3567b3ab3d4c | .NET 6.0.6; raspbian.11-arm; Linux 5.15.32-v7+ #1538 SMP Thu Mar 31 19:38:48 BST 2022)
2022-06-21 21:48:03|ArchiSteamFarm-516|INFO|ASF|InitCore() Copyright © 2015-2022 JustArchiNET
2022-06-21 21:48:22|ArchiSteamFarm-516|INFO|ASF|InitPlugins() Initializing Plugins...
2022-06-21 21:48:30|ArchiSteamFarm-516|INFO|ASF|InitPlugins() Loading ASFEnhance V1.6.5.579...
2022-06-21 21:48:30|ArchiSteamFarm-516|INFO|ASF|OnLoaded() 
==========================================
 █████╗ ███████╗███████╗███████╗███╗   ██╗██╗  ██╗ █████╗ ███╗   ██╗ ██████╗███████╗
██╔══██╗██╔════╝██╔════╝██╔════╝████╗  ██║██║  ██║██╔══██╗████╗  ██║██╔════╝██╔════╝
███████║███████╗█████╗  █████╗  ██╔██╗ ██║███████║███████║██╔██╗ ██║██║     █████╗  
██╔══██║╚════██║██╔══╝  ██╔══╝  ██║╚██╗██║██╔══██║██╔══██║██║╚██╗██║██║     ██╔══╝  
██║  ██║███████║██║     ███████╗██║ ╚████║██║  ██║██║  ██║██║ ╚████║╚██████╗███████╗
╚═╝  ╚═╝╚══════╝╚═╝     ╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝╚═╝  ╚═╝╚═╝  ╚═══╝ ╚═════╝╚══════╝
ASFEnhance Version 1.6.5.579
Developed by Chr_, email chr@chrxw.com
https://afdian.net/@chr233
==========================================
Use Command "ASFEVERSION" / "AV" to check the plugin's latest version
Use Command "ASFEUPDATE" / "AU" to update the plugin
==========================================

2022-06-21 21:48:30|ArchiSteamFarm-516|INFO|ASF|InitPlugins() ASFEnhance has been loaded successfully!
2022-06-21 21:48:30|ArchiSteamFarm-516|INFO|ASF|InitPlugins() Loading ASFFreeGamesPlugin V1.2.3.0...
2022-06-21 21:48:30|ArchiSteamFarm-516|INFO|ASF|InitPlugins() ASFFreeGamesPlugin has been loaded successfully!
2022-06-21 21:48:30|ArchiSteamFarm-516|INFO|ASF|InitPlugins() Loading SteamTokenDumperPlugin V5.2.7.5...
2022-06-21 21:48:30|ArchiSteamFarm-516|INFO|ASF|InitPlugins() SteamTokenDumperPlugin has been loaded successfully!
2022-06-21 21:48:30|ArchiSteamFarm-516|INFO|ASF|InitPlugins() You've loaded one or multiple custom plugins into ASF. Since we're unable to offer support for modded setups, please contact the appropriate developers of the plugins that you decided to use in case of any issues.
2022-06-21 21:48:57|ArchiSteamFarm-516|INFO|ASF|UpdateAndRestart() ASF will automatically check for new versions every 12 hours.
2022-06-21 21:48:57|ArchiSteamFarm-516|INFO|ASF|Update() Checking for new version...
2022-06-21 21:49:02|ArchiSteamFarm-516|INFO|ASF|Update() Local version: 5.2.7.5 | Remote version: 5.2.7.5
2022-06-21 21:49:02|ArchiSteamFarm-516|INFO|ASF|Load() Loading STD global cache...
2022-06-21 21:49:03|ArchiSteamFarm-516|INFO|ASF|Load() Validating STD global cache integrity...
2022-06-21 21:49:03|ArchiSteamFarm-516|INFO|ASF|OnASFInit() SteamTokenDumperPlugin has been initialized successfully, thank you in advance for your help. The first submission will happen in approximately 14 minutes from now.
2022-06-21 21:49:04|ArchiSteamFarm-516|INFO|ASF|Start() Starting IPC server...
2022-06-21 21:49:14|ArchiSteamFarm-516|INFO|Microsoft.Hosting.Lifetime|Now listening on: [serverip]
2022-06-21 21:49:15|ArchiSteamFarm-516|INFO|Microsoft.Hosting.Lifetime|Application started. Press Ctrl+C to shut down.
2022-06-21 21:49:15|ArchiSteamFarm-516|INFO|Microsoft.Hosting.Lifetime|Hosting environment: Production
2022-06-21 21:49:15|ArchiSteamFarm-516|INFO|Microsoft.Hosting.Lifetime|Content root path: /home/pi/Desktop/ArchiSteamFarm
2022-06-21 21:49:15|ArchiSteamFarm-516|INFO|ASF|Start() IPC server ready!
2022-06-21 21:49:21|ArchiSteamFarm-516|INFO|JourneyOver|Start() Starting...
2022-06-21 21:49:21|ArchiSteamFarm-516|INFO|JourneyOver|Connect() Connecting...
2022-06-21 21:49:22|ArchiSteamFarm-516|INFO|JourneyOver|OnConnected() Connected to Steam!
2022-06-21 21:49:22|ArchiSteamFarm-516|INFO|JourneyOver|OnConnected() Logging in...
2022-06-21 21:49:27|ArchiSteamFarm-516|INFO|JourneyOver|OnLoggedOn() Successfully logged on as 76561198037630370/Journey_Over.
2022-06-21 21:49:27|ArchiSteamFarm-516|INFO|JourneyOver|Init() Logging in to ISteamUserAuth...
2022-06-21 21:49:28|ArchiSteamFarm-516|INFO|JourneyOver|Init() Success!
2022-06-21 21:49:39|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Retrieving a total of 8 app access tokens...
2022-06-21 21:49:39|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Retrieving 8 app access tokens...
2022-06-21 21:49:47|ArchiSteamFarm-516|INFO|JourneyOver|IsAnythingToFarm() Checking first badge page...
2022-06-21 21:49:50|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Finished retrieving 8 app access tokens.
2022-06-21 21:49:50|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Finished retrieving a total of 8 app access tokens.
2022-06-21 21:49:50|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Retrieving all depots for a total of 8 apps...
2022-06-21 21:49:50|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Retrieving 8 app infos...
2022-06-21 21:49:51|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Finished retrieving 8 app infos.
2022-06-21 21:49:52|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Retrieving 37 depot keys...
2022-06-21 21:49:52|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Finished retrieving 37 depot keys.
2022-06-21 21:49:53|ArchiSteamFarm-516|INFO|JourneyOver|Refresh() Finished retrieving all depot keys for a total of 8 apps.
2022-06-21 21:49:54|ArchiSteamFarm-516|INFO|JourneyOver|IsAnythingToFarm() Checking other badge pages...
2022-06-21 21:49:56|ArchiSteamFarm-516|INFO|JourneyOver|StartFarming() We don't have anything to farm on this account!
2022-06-21 21:49:56|ArchiSteamFarm-516|INFO|JourneyOver|IsAnythingToFarm() Checking first badge page...
2022-06-21 21:49:58|ArchiSteamFarm-516|INFO|JourneyOver|IsAnythingToFarm() Checking other badge pages...
2022-06-21 21:49:59|ArchiSteamFarm-516|INFO|JourneyOver|StartFarming() We don't have anything to farm on this account!
2022-06-21 21:50:03|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] found 22 free games on reddit
2022-06-21 21:50:04|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/1599030 | Status: OK | Items: app/1599030

2022-06-21 21:50:04|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/798542 | Status: OK | Items: app/798542

2022-06-21 21:50:05|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/1472780 | Status: OK

2022-06-21 21:50:05|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/1910780 | Status: OK | Items: app/1910780

2022-06-21 21:50:06|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/1887560 | Status: OK | Items: app/1887560

2022-06-21 21:50:07|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/818040 | Status: OK

2022-06-21 21:50:07|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/708720 | Status: OK | Items: app/708720

2022-06-21 21:50:08|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/1755240 | Status: OK | Items: app/1755240

2022-06-21 21:50:08|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/1956740 | Status: OK | Items: app/1956740

2022-06-21 21:50:09|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: app/1909340 | Status: OK

2022-06-21 21:50:10|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 21:50:10|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 21:50:11|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 21:50:11|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 21:50:12|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 21:50:12|ArchiSteamFarm-516|WARN|JourneyOver|UrlPostToJsonObject() Request failed after 5 attempts!
2022-06-21 21:50:12|ArchiSteamFarm-516|DEBUG|JourneyOver|UrlPostToJsonObject() Request failing: https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 21:50:12|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: sub/730490 | Status: Fail/Timeout

2022-06-21 22:03:04|ArchiSteamFarm-516|INFO|ASF|SubmitData() There is no new data to submit, everything is up-to-date.
2022-06-21 22:20:03|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] found 22 free games on reddit
2022-06-21 22:20:03|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:20:04|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:20:05|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:20:05|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:20:06|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:20:06|ArchiSteamFarm-516|WARN|JourneyOver|UrlPostToJsonObject() Request failed after 5 attempts!
2022-06-21 22:20:06|ArchiSteamFarm-516|DEBUG|JourneyOver|UrlPostToJsonObject() Request failing: https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:20:06|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: sub/730490 | Status: Fail/Timeout

2022-06-21 22:29:18|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] found 22 free games on reddit
2022-06-21 22:29:18|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:29:19|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:29:20|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:29:20|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:29:21|ArchiSteamFarm-516|DEBUG|JourneyOver|InternalRequest() InternalServerError <- POST https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:29:21|ArchiSteamFarm-516|WARN|JourneyOver|UrlPostToJsonObject() Request failed after 5 attempts!
2022-06-21 22:29:21|ArchiSteamFarm-516|DEBUG|JourneyOver|UrlPostToJsonObject() Request failing: https://store.steampowered.com/checkout/addfreelicense/730490
2022-06-21 22:29:21|ArchiSteamFarm-516|INFO|ASF|CollectGames() [FreeGames] <JourneyOver> ID: sub/730490 | Status: Fail/Timeout

Desktop (please complete the following information):

  • OS: Raspbian GNU/Linux 11 (bullseye)
  • Version: Everything is up to date including ASF

Additional context
Add any other context about the problem here.
@woctezuma
Copy link

woctezuma commented Jun 22, 2022 •
edited
Loading

This seems to be the game/sub in particular that it is failing on https://steamdb.info/sub/730490/

Do you already own sub/586694?

Not really sure on how to reproduce as I already owned the sub/game that this is failing on, since I got it through ASFclaim.

Which ones do you own: app/1180660, sub/730490, sub/586694?

@maxisoft
Copy link
Owner

maxisoft commented Jun 22, 2022 •
edited
Loading

Hey,

The issue is more about a misleading/missing log and documentation informations.

As a fresh user you may have thought the plugin is stuck on adding only 1 game but it's not.
According to your logs and currently free steam games available, the plugin is working but I think there's no new free games that you don't own to be added for now.

About found X free games on reddit

The found 22 free games on reddit message means that the internal parser has found 22 addlicense entries on reddit.
That doesn't mean there is 22 free games going to be added for sure.
For instance a game fee offer may have expired or it's a dlc for a paid game that you don't own.

About Request failed after 5 attempts! warnings:

What you describe is revelent to the plugin logic.

The plugin checks if the steam user has already the game (using steamkit at this line) before adding it
But for some reasons this check has false negatives (ie you already have a game title but it says you don't) on some titles/conditions.

So there's a workaround that is to tryhard to add the title (5 times) and internally blacklist it for 24hr in case of errors.

Resolution

I'll edit log messages to make it more clear and document the Request failed behavior into the readme.

@maxisoft maxisoft added the documentation Improvements or additions to documentation label Jun 22, 2022
@maxisoft maxisoft self-assigned this Jun 22, 2022
@maxisoft maxisoft added the good first issue Good for newcomers label Jun 22, 2022
@JourneyOver
Copy link
Author

JourneyOver commented Jun 22, 2022 •
edited
Loading

@woctezuma

This seems to be the game/sub in particular that it is failing on steamdb.info/sub/730490

Do you already own sub/586694?

Not really sure on how to reproduce as I already owned the sub/game that this is failing on, since I got it through ASFclaim.

Which ones do you own: app/1180660, sub/730490, sub/586694?

Going by what both steam and steamdb tell me I own all of these things, but on steamdb for sub/730490 instead of saying owned where the install usually is, it just says install if I go to any of the others (app/1180660 and sub/586694) though it says owned instead of install. If I go to https://store.steampowered.com/sub/730490 and try to add it (it says I already own the game in the items included section) it throws me to a site error page with:

OOPS, SORRY!

An error was encountered while processing your request:

This product is already available in your Steam library.

Looking at things more I guess it's technically because I own the game already through the 2021 promotion sub/586694, but the sub/730490 is a newer promotion (2022) and ASFFreeGames isn't able to take that into account so it sits there and tries to continue to claim the 2022 promotion every 30 minutes?

@maxisoft

Hey,

The issue is more about a misleading/missing log and documentation informations.

As a fresh user you may have thought the plugin is stuck on adding only 1 game but it's not. According to your logs and currently free steam games available, the plugin is working but I think there's no new free games that you don't own to be added for now.

Okay so I think I understand, and it's pretty much the gist of what I had said above to woc about the whole Looking at things more I guess it's technically because I own the game already through the 2021 promotion `sub/586694`, but the `sub/730490` is a newer promotion (2022) and ASFFreeGames isn't able to take that into account so it sits there and tries to continue to claim the 2022 promotion every 30 minutes?

About found X free games on reddit

The found 22 free games on reddit message means that the internal parser has found 22 addlicense entries on reddit. That doesn't mean there is 22 free games going to be added for sure. For instance a game fee offer may have expired or it's a dlc for a paid game that you don't own.

Understood.

About Request failed after 5 attempts! warnings:

What you describe is revelent to the plugin logic.

The plugin checks if the steam user has already the game (using steamkit at this line) before adding it But for some reasons this check has false negatives (ie you already have a game title but it says you don't) on some titles/conditions.

So there's a workaround that is to tryhard to add the title (5 times) and internally blacklist it for 24hr in case of errors.

Understood as well, and since I had looked more into it I think I know the reasoning on why it continues to fail now as I had mentioned in this post. Main thing though is that it still is just tryhard trying to add the title and never blacklisted it even after going on 12 attempts of trying to tryhard add the title as of this message. Unless I misunderstood and it did blacklist it but it'll still try to add the title regardless until the promotion is over?

Resolution

I'll edit log messages to make it more clear and document the Request failed behavior into the readme.

That would be great.

@maxisoft maxisoft reopened this Oct 23, 2022
@maxisoft maxisoft reopened this Oct 23, 2022
@maxisoft maxisoft moved this to Todo in ASFFreeGames Nov 4, 2022
@maxisoft maxisoft moved this from Todo to In Progress in ASFFreeGames Nov 4, 2022
@maxisoft maxisoft linked a pull request Dec 26, 2022 that will close this issue
added options to skip f2p games and dlc + net 7.0 #17
Merged
4 tasks
Repository owner moved this from In Progress to Done in ASFFreeGames Dec 26, 2022
@maxisoft maxisoft mentioned this issue Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxisoft maxisoft

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
ASFFreeGames
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added options to skip f2p games and dlc + net 7.0 maxisoft/ASFFreeGames
3 participants
@woctezuma @maxisoft @JourneyOver