Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: Inconsistent naming #5725

Closed
sanderux opened this issue Oct 3, 2017 · 10 comments
Closed

RTL: Inconsistent naming #5725

sanderux opened this issue Oct 3, 2017 · 10 comments
Assignees

Comments

@sanderux
Copy link
Contributor

sanderux commented Oct 3, 2017

I propose we consistently refer to RTL as Return To Launch.

image

@DonLakeFlyer
Copy link
Contributor

Combo box values come from firmware parameter meta data. So that requires a firmware change. Happy to change to anything if you can sync up what firmware wants to call it.

@DonLakeFlyer DonLakeFlyer added this to the Release v3.3 milestone Oct 5, 2017
@dagar
Copy link
Member

dagar commented Oct 8, 2017

For now it should probably be "return to land" everywhere, although it may be worth distinguishing "return to home" and "return to land" soon with all these other RTL variations (RTL -> mission landing, smart RTL, RTL with safe points).

@hamishwillee
Copy link
Contributor

although it may be worth distinguishing "return to home" and "return to land" soon with all these other RTL variations (RTL -> mission landing, smart RTL, RTL with safe points).

Yes if these are different "modes" and no if they are the same mode with some parameter that define where the land point is. We could consider something like "Safe Land" mode as well to keep this generic.
For docs we are currently standardising against what QGC says in the mode selection boxes - so it is "Return" mode.

@sanderux
Copy link
Contributor Author

sanderux commented Oct 9, 2017

For now it should probably be "return to land" everywhere

What does that mean? I don't even know if that's correct English

I would propose 3 modes, or the latter 2 as options on the first
Return To Launch (RTL)
Smart Return To Launch (SRTL)
Fail Safe Land (FSL) (Rally point, Home or Destination, which ever is closest)

@Antiheavy
Copy link

Antiheavy commented Oct 9, 2017

oh my favorite topic! Yeah, the RTL naming is inconsistent all over the place within the various MAVlink family ground stations and firmwares and documentation.

Fixed Wing and VTOL are sort of fundamentally different with how they do/should work. IMHO Return to Launch isn't the right term to use for a number of reasons. I think "Return to Home" (RTH) and "Return to Land" (RTL) are the better and more commonly used terms in the industry.

Return to Land
Traditionally (going back to before the advent of quad copters et al) RTL has generally, and most often, stood for Return to Land. This term is somewhat fixed wing focused, but that was all we had to consider back then (we had helicopters, but they called it Return to Land too). There was also a concept of Return to Home, but that involved loitering (circling or hovering) above the Home point and typically was not associated with actually landing.

Return to Land should be associated with returning to a pre-programmed "landing" location which might be a "Land" waypoint or pattern of some type.

Return to Home
Now that VTOL multicopters are the thing the concept of Return to Home (RTH) has become the defacto standard behavior and terminology for VTOL vehicles returning to the intended landing spot. VTOLs simplified the whole thing by combining the Home point with the default land point and having it automatically set upon launch. Ingenious really! However, thus spawns our confusion.

Return to Home actually best describes what the autopilot is actually doing. Most commercially sold systems update the Home point upon takeoff and inform the user that this is happening. So while "Return to Launch" is effectively what is going to happen, it isn't what the autopilot is actually thinking it is doing. Also many systems allow the user to change the Home point during flight, so a Return would no longer go to the Launch point.

Advanced behaviors
advanced behaviors such as the smart return and rally points or other topics, well, that adds another dimension to the discussion and doesn't necessarily have established industry norms to follow yet.

@hamishwillee
Copy link
Contributor

For now it should probably be "return to land" everywhere

What does that mean? I don't even know if that's correct English

@sanderux

  • This is correct English but it is ambiguous. It means either got back to be over land (e.g. from the sea) or it might mean "return with intention of landing". In either case there is no indication of where you are returning to (home, launch, or safe point).
  • Return and land is closer to what we are after, but again, loses the destination landing point.
  • Currently QGC refers to this as "Return" which is (coincidentally) the most accurate, since it doesn't imply where we return, and it doesn't imply landing (which we don't necessarily do based on parameters).

@Antiheavy Given the inconsistency of naming conventions I wouldn't be too tied up about the historical naming conventions - though if we end up with a mode that returns to home then we'd be silly not to use that name.

I'd suggest that PX4 decide all the return behaviours we want and how they are configured (either as variations of a single mode or as unique modes) and then we work out good names from that. Lots of options - Return to Base, Return, Travel to Safe Zone, Safe Recover, etc. (Recover not bad, since it covers both home, launch or safe points)

@tubeme
Copy link

tubeme commented Oct 30, 2017

I like the @hamishwillee "Safe Land" when landing on alternative spot.
The other could just stay "Return" with a warning message if it is Failsafe Return. And "Smart Return" the @sanderux distinction. We don't have to make it more complicated. The simpler the better in the pilot's cockpit if I can say it this way. Voice messaging will announce if it is Failsafe Return as well or smart return or safe land.

  • Return (Comanded or Failsafe)
  • Smart Return
  • Safe Land

@Antiheavy
Copy link

I think this can be viewed even more simply in that "normal" Return and "smart" Return are really the same thing from a user perspective, it is just "normal" return climbs to a return alt to avoid potential obstacles and "smart" return follows a pre-flown path back to avoid potential obstacles. The user will have selected one of the options from the params and will expect that behavior. So from QGC standpoint just the word "Return" is good enough for both.

"Safe Land" or Rally or whatever if finally is called really should be a separate mode and not part of Return.

@DonLakeFlyer DonLakeFlyer modified the milestones: Release v3.3, Release v3.4 Dec 30, 2017
@DonLakeFlyer DonLakeFlyer modified the milestones: Release v3.4, Release v3.5 Jun 20, 2018
@DonLakeFlyer DonLakeFlyer modified the milestones: Release v3.5, Release v3.6 Jan 19, 2019
@DonLakeFlyer
Copy link
Contributor

This has changed to "Launch".

@Antiheavy
Copy link

I think it is still just called Return Mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants