-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL: Inconsistent naming #5725
Comments
Combo box values come from firmware parameter meta data. So that requires a firmware change. Happy to change to anything if you can sync up what firmware wants to call it. |
For now it should probably be "return to land" everywhere, although it may be worth distinguishing "return to home" and "return to land" soon with all these other RTL variations (RTL -> mission landing, smart RTL, RTL with safe points). |
Yes if these are different "modes" and no if they are the same mode with some parameter that define where the land point is. We could consider something like "Safe Land" mode as well to keep this generic. |
What does that mean? I don't even know if that's correct English I would propose 3 modes, or the latter 2 as options on the first |
oh my favorite topic! Yeah, the RTL naming is inconsistent all over the place within the various MAVlink family ground stations and firmwares and documentation. Fixed Wing and VTOL are sort of fundamentally different with how they do/should work. IMHO Return to Launch isn't the right term to use for a number of reasons. I think "Return to Home" (RTH) and "Return to Land" (RTL) are the better and more commonly used terms in the industry. Return to Land Return to Land should be associated with returning to a pre-programmed "landing" location which might be a "Land" waypoint or pattern of some type. Return to Home Return to Home actually best describes what the autopilot is actually doing. Most commercially sold systems update the Home point upon takeoff and inform the user that this is happening. So while "Return to Launch" is effectively what is going to happen, it isn't what the autopilot is actually thinking it is doing. Also many systems allow the user to change the Home point during flight, so a Return would no longer go to the Launch point. Advanced behaviors |
@Antiheavy Given the inconsistency of naming conventions I wouldn't be too tied up about the historical naming conventions - though if we end up with a mode that returns to home then we'd be silly not to use that name. I'd suggest that PX4 decide all the return behaviours we want and how they are configured (either as variations of a single mode or as unique modes) and then we work out good names from that. Lots of options - Return to Base, Return, Travel to Safe Zone, Safe Recover, etc. (Recover not bad, since it covers both home, launch or safe points) |
I like the @hamishwillee "Safe Land" when landing on alternative spot.
|
I think this can be viewed even more simply in that "normal" Return and "smart" Return are really the same thing from a user perspective, it is just "normal" return climbs to a return alt to avoid potential obstacles and "smart" return follows a pre-flown path back to avoid potential obstacles. The user will have selected one of the options from the params and will expect that behavior. So from QGC standpoint just the word "Return" is good enough for both. "Safe Land" or Rally or whatever if finally is called really should be a separate mode and not part of Return. |
This has changed to "Launch". |
I think it is still just called Return Mode. |
I propose we consistently refer to RTL as Return To Launch.
The text was updated successfully, but these errors were encountered: