From 1bfdd5a044f064a05ee3201b1bd5123da4c8f49e Mon Sep 17 00:00:00 2001
From: ugol-1 <ugol-1@potatomatic.com>
Date: Tue, 25 Jun 2024 20:27:24 +0000
Subject: [PATCH] Fixed unresolved symbol runtime error due to not linking to
 yaml-cpp properly

---
 mavros_extras/CMakeLists.txt | 11 +++++++----
 mavros_extras/package.xml    |  1 -
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/mavros_extras/CMakeLists.txt b/mavros_extras/CMakeLists.txt
index dc0fd0cbb..a2bd0ea3b 100644
--- a/mavros_extras/CMakeLists.txt
+++ b/mavros_extras/CMakeLists.txt
@@ -32,8 +32,7 @@ find_package(libmavconn REQUIRED)
 
 find_package(eigen3_cmake_module REQUIRED)
 find_package(Eigen3 REQUIRED)
-# find_package(yaml_cpp REQUIRED)
-find_package(yaml_cpp_vendor REQUIRED)
+find_package(yaml-cpp REQUIRED)
 
 ## Find GeographicLib
 # Append to CMAKE_MODULE_PATH since debian/ubuntu installs
@@ -153,7 +152,9 @@ ament_target_dependencies(mavros_extras_plugins
   tf2_eigen
   message_filters
   Eigen3
-  yaml_cpp_vendor
+)
+target_link_libraries(mavros_extras_plugins
+  yaml-cpp
 )
 pluginlib_export_plugin_description_file(mavros mavros_plugins.xml)
 
@@ -171,9 +172,11 @@ ament_target_dependencies(mavros_extras
   sensor_msgs
   mavros_msgs
   #console_bridge
-  yaml_cpp_vendor
   urdf
 )
+target_link_libraries(mavros_extras
+  yaml-cpp
+)
 rclcpp_components_register_node(mavros_extras PLUGIN "mavros::extras::ServoStatePublisher" EXECUTABLE servo_state_publisher)
 
 install(TARGETS mavros_extras mavros_extras_plugins
diff --git a/mavros_extras/package.xml b/mavros_extras/package.xml
index eeb0d29f5..4f2770c68 100644
--- a/mavros_extras/package.xml
+++ b/mavros_extras/package.xml
@@ -49,7 +49,6 @@
   <depend>rcpputils</depend>
   <depend>urdf</depend>
   <depend>yaml-cpp</depend>
-  <depend>yaml_cpp_vendor</depend>
 
   <!-- message packages -->
   <depend>diagnostic_msgs</depend>