Access to MavlinkCommandSender::_work_queue without locking the mutex

[snow910]

void MavlinkCommandSender::queue_command_async(
    const CommandLong& command, const CommandResultCallback& callback)
{
    if (_command_debugging) {
        LogDebug() << "COMMAND_LONG " << (int)(command.command) << " to send to "
                   << (int)(command.target_system_id) << ", " << (int)(command.target_component_id);
    }

    CommandIdentification identification = identification_from_command(command);

    for (const auto& work : _work_queue) {
        if (work->identification == identification && callback == nullptr) {
            if (_command_debugging) {
                LogDebug() << "Dropping command " << static_cast<int>(identification.command)
                           << " that is already being sent";
            }
            return;
        }
    }
    // ...
}

Access to _work_queue without locking the mutex

[julianoes]

Hmm 🤔, that doesn't look right indeed. Do you want to make a pull request to fix it?

[julianoes]

Given the system_tests segfaults, I wanted to try this out immediately and did the PR, sorry.

[snow910]

Thank you :)