Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in C++ standard compatibility #30

Closed
valgur opened this issue Dec 31, 2023 · 1 comment
Closed

Regression in C++ standard compatibility #30

valgur opened this issue Dec 31, 2023 · 1 comment

Comments

@valgur
Copy link

valgur commented Dec 31, 2023

I was updating the plf_list recipe for Conan Center (conan-io/conan-center-index#21933) and noticed that after a version bump from v2.57 to v2.70 the library no longer only compiles without issues with the C++17 standard and compatible compiler versions. Older compiler versions (GCC < 7 and Clang < 5) fail with

In file included from plf_list/all/test_package/test_package.cpp:1:0:
plf_list.h: In member function ‘plf::list<element_type, allocator_type>::iterator plf::list<element_type, allocator_type>::unordered_find_single(const element_type&) const’:
plf_list.h:3497:45: error: missing template arguments before ‘(’ token
   return unordered_find_single(plf::equal_to(element_to_match));
                                             ^
plf_list.h: In member function ‘plf::list<plf::list<element_type, allocator_type>::list_iterator<false> > plf::list<element_type, allocator_type>::unordered_find_multiple(const element_type&, plf::list<element_type, allocator_type>::size_type) const’:
plf_list.h:3584:47: error: missing template arguments before ‘(’ token
   return unordered_find_multiple(plf::equal_to(element_to_match), number_to_find);
                                               ^
plf_list.h: In member function ‘plf::list<plf::list<element_type, allocator_type>::list_iterator<false> > plf::list<element_type, allocator_type>::unordered_find_all(const element_type&) const’:
plf_list.h:3651:42: error: missing template arguments before ‘(’ token
   return unordered_find_all(plf::equal_to(element_to_match));

I thought you might want to know as the stated expected compatibility is for C++98.

@mattreecebentley
Copy link
Owner

Sorry for delay, just saw this yesterday,
should be all fixed now. Not sure what happened there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants