-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Versioning: ZeroWidthJoiner
Removal
#58
Comments
I'm thinking global variable ZeroWidthJoiner is not used for everyone properly since the variable is overwritten in init function. |
However, I'm also considering upgrading the minor version. |
To my knowledge, I was the only one using it and I'm ok with this change. |
This also reintroduces the following issues when building older projects that were pinned to a version of tview that relied on
To resolve the issue, I updated the project // github.com/rivo/tview v0.0.0-20210111184519-c818a0c789ee // original
// github.com/mattn/go-runewidth v0.0.8 // indirect - via tview above
github.com/rivo/tview v0.0.0-20230406072732-e22ce9588bb4 // updated
github.com/mattn/go-runewidth v0.0.14 // indirect - via tview above I would have preferred to stick with the original pinned Even though go-runewidth v0.0.8 has the Not sure what to make of it, and probably not that important, but just presenting the info in case it helps someone else. |
Special I would think that if there's an old project which uses an old version of
In any case, |
Thanks for the feedback @rivo. I've upgraded to the latest version of your package, and everything seems to be working well. Thanks for your backwards-compatibility efforts! |
ZeroWidthJoiner
was removed afterv0.0.9
: https://github.com/mattn/go-runewidth/blob/v0.0.9/runewidth.go#L14The next version was
v0.0.10
, but this introduced a breaking API change.While being
v0
means you can introduce breaking API changes, would it be possible to get av1
release that can ensure API stability?It's fine to just keep cutting new versions when API changes happen, but right now it makes managing Go Module dependencies rather painful, since it just assumes patch versions don't introduce breaking changes.
The text was updated successfully, but these errors were encountered: