You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rollup merge of rust-lang#120890 - TimNN:relax-patches-check, r=onur-ozkan
Adapt `llvm-has-rust-patches` validation to take `llvm-config` into account.
This adapts an assertion that was added in rust-lang#119556.
The current assertion does not take the `llvm-config` setting into accounts, which does not match the `llvm-has-rust-patches` documentation, which states:
> This would be used in conjunction with either an llvm-config or build.submodules = false.
(It also breaks my workflow: I build LLVM separately, but do have the rust patches applied).
---
**edit:** Originally this PR just removed the assertion, but it now implements the alternative mentioned here:
An alternative fix would be to take `llvm-config` into account in the assertion, but to me the assertion seems to provide little value, thus the simpler fix of just removing it.
cc `@onur-ozkan,` in case I'm missing a reason to keep the assertion.
0 commit comments