Skip to content

Commit 955cbdf

Browse files
authored
Rollup merge of rust-lang#120890 - TimNN:relax-patches-check, r=onur-ozkan
Adapt `llvm-has-rust-patches` validation to take `llvm-config` into account. This adapts an assertion that was added in rust-lang#119556. The current assertion does not take the `llvm-config` setting into accounts, which does not match the `llvm-has-rust-patches` documentation, which states: > This would be used in conjunction with either an llvm-config or build.submodules = false. (It also breaks my workflow: I build LLVM separately, but do have the rust patches applied). --- **edit:** Originally this PR just removed the assertion, but it now implements the alternative mentioned here: An alternative fix would be to take `llvm-config` into account in the assertion, but to me the assertion seems to provide little value, thus the simpler fix of just removing it. cc `@onur-ozkan,` in case I'm missing a reason to keep the assertion.
2 parents 09bbcd6 + fd470e5 commit 955cbdf

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/bootstrap/src/core/config/config.rs

+3-4
Original file line numberDiff line numberDiff line change
@@ -1810,10 +1810,9 @@ impl Config {
18101810
target.llvm_config = Some(config.src.join(s));
18111811
}
18121812
if let Some(patches) = cfg.llvm_has_rust_patches {
1813-
assert_eq!(
1814-
config.submodules,
1815-
Some(false),
1816-
"cannot set `llvm-has-rust-patches` for a managed submodule (set `build.submodules = false` if you want to apply patches)"
1813+
assert!(
1814+
config.submodules == Some(false) || cfg.llvm_config.is_some(),
1815+
"use of `llvm-has-rust-patches` is restricted to cases where either submodules are disabled or llvm-config been provided"
18171816
);
18181817
target.llvm_has_rust_patches = Some(patches);
18191818
}

0 commit comments

Comments
 (0)