From 9f51454926e24b662bf7422bdc264e80b10599ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Kr=C3=BCger?= Date: Sun, 23 Sep 2018 10:54:58 +0200 Subject: [PATCH] job queue: remove outdated comment about reenabling compile-progress once #5695 is fixed The issue has been resolved and the compile-progress has been reenabled already. --- src/cargo/core/compiler/job_queue.rs | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/cargo/core/compiler/job_queue.rs b/src/cargo/core/compiler/job_queue.rs index 2c84dd3e8b9..94aa2a58f15 100644 --- a/src/cargo/core/compiler/job_queue.rs +++ b/src/cargo/core/compiler/job_queue.rs @@ -225,17 +225,6 @@ impl<'a> JobQueue<'a> { // After a job has finished we update our internal state if it was // successful and otherwise wait for pending work to finish if it failed // and then immediately return. - // - // TODO: the progress bar should be re-enabled but unfortunately it's - // difficult to do so right now due to how compiler error messages - // work. Cargo doesn't redirect stdout/stderr of compiler - // processes so errors are not captured, and Cargo doesn't know - // when an error is being printed, meaning that a progress bar - // will get jumbled up in the output! To reenable this progress - // bar we'll need to probably capture the stderr of rustc and - // capture compiler error messages, but that also means - // reproducing rustc's styling of error messages which is - // currently a pretty big task. This is issue #5695. let mut error = None; let mut progress = Progress::with_style("Building", ProgressStyle::Ratio, cx.bcx.config); let total = self.queue.len();