Skip to content

Commit

Permalink
Drop lxml[html_clean] and use lxml_html_clean (#41)
Browse files Browse the repository at this point in the history
Fixes #40

This PR drops dependency `lxml[html_clean]` since the extra is not resolved properly by `pip`.
Instead, we use both `lxml` (5.2.0) and `lxml-html-clean` (0.1.0).

Signed-off-by: Valentin <valentin@waldeck.dev>
  • Loading branch information
waldeck-dev authored Apr 1, 2024
1 parent ccbee2c commit 019220f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install beautifulsoup4 lxml[html_clean]
python -m pip install beautifulsoup4 lxml lxml-html-clean
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Run tests
run: |
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ dynamic = [
]
dependencies = [
"beautifulsoup4",
"lxml[html_clean]>=5.2.0",
"lxml>=5.2.0",
"lxml-html-clean>=0.1.0",
]
[project.urls]
Homepage = "https://github.com/matthiask/html-sanitizer/"
Expand Down
3 changes: 2 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
[testenv]
deps =
wheel
lxml[html_clean]
lxml
lxml-html-clean
beautifulsoup4
coverage
changedir = {toxinidir}
Expand Down

0 comments on commit 019220f

Please sign in to comment.