From 4dcfb0e022d8b62546a26989e05f00129ab43f6d Mon Sep 17 00:00:00 2001 From: Matthew D'Alonzo Date: Fri, 26 Jul 2024 14:41:04 -0400 Subject: [PATCH] Resolve Comments * Change INVALID_ARGUMENT to FAILED_PRECONDITION * Remove invokemethod constant --- .../java/org/eclipse/uprotocol/Constants/ActionCommands.java | 1 - .../java/src/main/java/org/eclipse/uprotocol/TestAgent.java | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/test_agent/java/src/main/java/org/eclipse/uprotocol/Constants/ActionCommands.java b/test_agent/java/src/main/java/org/eclipse/uprotocol/Constants/ActionCommands.java index 3fe8f799..08afd75c 100644 --- a/test_agent/java/src/main/java/org/eclipse/uprotocol/Constants/ActionCommands.java +++ b/test_agent/java/src/main/java/org/eclipse/uprotocol/Constants/ActionCommands.java @@ -25,7 +25,6 @@ public class ActionCommands { public static final String SEND_COMMAND = "send"; public static final String REGISTER_LISTENER_COMMAND = "registerlistener"; public static final String UNREGISTER_LISTENER_COMMAND = "unregisterlistener"; - public static final String INVOKE_METHOD_COMMAND = "invokemethod"; public static final String RESPONSE_ON_RECEIVE = "onreceive"; public static final String RESPONSE_RPC = "rpcresponse"; public static final String SERIALIZE_URI = "uri_serialize"; diff --git a/test_agent/java/src/main/java/org/eclipse/uprotocol/TestAgent.java b/test_agent/java/src/main/java/org/eclipse/uprotocol/TestAgent.java index 525d2c4b..b9aa6dfa 100644 --- a/test_agent/java/src/main/java/org/eclipse/uprotocol/TestAgent.java +++ b/test_agent/java/src/main/java/org/eclipse/uprotocol/TestAgent.java @@ -158,12 +158,12 @@ private static Object handleInitializeTransportCommand(Map jsonD if (transportName.equals("socket")) { transport = new SocketUTransport(uri); } else { - UStatus status = UStatus.newBuilder().setCode(UCode.INVALID_ARGUMENT).setMessage("").build(); + UStatus status = UStatus.newBuilder().setCode(UCode.FAILED_PRECONDITION).setMessage("").build(); sendToTestManager(status, ActionCommands.INITIALIZE_TRANSPORT, testID); } } catch (IOException e) { e.printStackTrace(); - UStatus status = UStatus.newBuilder().setCode(UCode.INVALID_ARGUMENT).setMessage("").build(); + UStatus status = UStatus.newBuilder().setCode(UCode.FAILED_PRECONDITION).setMessage("").build(); sendToTestManager(status, ActionCommands.INITIALIZE_TRANSPORT, testID); } UStatus status = UStatus.newBuilder().setCode(UCode.OK).setMessage("").build();