Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include end date for intervals in exposure dataframe #21

Closed
MatthewCaseres opened this issue Feb 1, 2023 · 1 comment · Fixed by #26
Closed

include end date for intervals in exposure dataframe #21

MatthewCaseres opened this issue Feb 1, 2023 · 1 comment · Fixed by #26

Comments

@MatthewCaseres
Copy link

MatthewCaseres commented Feb 1, 2023

Main motivation for the issue is that it helps implement #7

There is an Rcpp algorithm for assigning transactions to date intervals that uses end dates of intervals.

It is maybe possible to implement this by determining the policy year of the transactions, but I imagine some complexities if #20 gets implemented or maybe dealing with truncation dates.

edit: any input on what the right approach is for #7 and the inclusion of end dates on exposures?

@mattheaphy
Copy link
Owner

Thanks! There's a large update to dplyr that was released this week that allows for rolling and overlapping joins. I think this might be an ideal candidate for #7. However, that will require an end date as well. I can look to add this.

I'll also look at the Rcpp algorithm to see how it compares to using dplyr.

@mattheaphy mattheaphy linked a pull request Feb 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants