-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-3959] implement Option to "Create New Category" under the "Move To..." option in the sidebar #4057
base: main
Are you sure you want to change the base?
Conversation
Hello @cannalee90, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, some guidenace around how to get properly the new created category id.
@jespino I apply your review! thanks a lot |
I applied your review. @jespino and feel free to talk to me anything you bother you. |
@cannalee90 this is awesome! It works so well! Could you please add some unit tests for this? Everything else looks fantastic! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks awesome! Could you add some unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tiny detail, and as @harshilsharma63 suggested, would be great to have some unit tests for this. But for me the code is ready (apart from the little suggestion on parameter name).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now Is ready for me, still waiting for the unit tests requested from @harshilsharma63
Ill try my best! |
I'm trying to add some unit test in sidebarBoarItem.test.tsx but have problem updating snapshot for showing nested menu. Would you help me on this? Here is What I wrote
|
Oh finally I made it! please review for the test @harshilsharma63 |
@harshilsharma63 - Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM 👍
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
I just implement option to create new category under the option in the sidebar
please look through the last commit about moving board to newly created category
I'm not it is right way to do but I have no idea how to get category id that I just created
Ticket Link
Fixes #3959