Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NoMethodError #27

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix: NoMethodError #27

merged 1 commit into from
Aug 31, 2023

Conversation

baraidrissa
Copy link
Contributor

undefined method `upcase' for nil:NilClass

@matteoredz matteoredz changed the title fix NoMethodError fix: NoMethodError Aug 31, 2023
matteoredz
matteoredz requested changes Aug 31, 2023
View reviewed changes
lib/itax_code/parser.rb Outdated Show resolved Hide resolved
@matteoredz
Copy link
Owner

@baraidrissa questo repo utilizza release-please che si basa sui conventional commits. Potresti fare amend del tuo commit fix NoMethodError usando la sintassi corretta fix: NoMethodError?

@baraidrissa
fix: NoMethodError
4142133 
fix: undefined method 'upcase' for nil:NilClass
@matteoredz matteoredz added the bug Something isn't working label Aug 31, 2023
@baraidrissa baraidrissa force-pushed the fix-undefined-method-upcase branch from bb5f1d6 to 4142133 Compare August 31, 2023 10:40
@baraidrissa
Copy link
Contributor Author

Ciao @matteoredz ,
sono state fatte le correzioni indicate.

Grazie

@matteoredz matteoredz self-requested a review August 31, 2023 10:45
@matteoredz matteoredz self-assigned this Aug 31, 2023
matteoredz
matteoredz approved these changes Aug 31, 2023
View reviewed changes
Copy link
Owner

@matteoredz matteoredz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matteoredz matteoredz merged commit 15470d1 into matteoredz:main Aug 31, 2023
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteoredz matteoredz matteoredz approved these changes

Assignees

@matteoredz matteoredz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baraidrissa @matteoredz