isUserless doesn't work properly

[mpivchev]

When I first open the app, I switchToUserless and when I call isUserless it returns true.
However, when I open the app and switchToUserless again, all of a sudden `isUserless' now returns false, even though that's not true.

Examples

When app opens for the first time:

Second time:

Also, because isUserless doesn't work properly, my app proceeds to load the account data of the userless account that doesn't exist, and crashes.

Is this how it's supposed to be, since before 1.0.0 isUserless always returned true if the app was not authenticated with a user account

[mattbdean]

Can you post the relevant code?

[mpivchev]

There isn't anything else besides this

 private static class AuthenticateAsUserlessTask extends AsyncTask<Void, Void, Void> {
        @Override
        protected Void doInBackground(Void... voids) {
            try {
                App.getAccountHelper().switchToUserless();
            } catch (OAuthException e) {
                e.printStackTrace();
            }

            return null;
        }
    }

And this

 public static boolean hasUser() {
        Log.d(TAG, "isUserless: " + String.valueOf(App.getAccountHelper().getReddit().getAuthMethod().isUserless()));
        return !App.getAccountHelper().getReddit().getAuthMethod().isUserless();
    }

[mattbdean]

Gonna need a bit more context here. When is AuthenticateAsUserlessTask executed? What about hasUser?

[mpivchev]

I call it on onResume where I authenticate as userless (just for now just as I am testing) and after that load the user data (which of course won't be done if the boolean returned the right thing)

 @Override
    protected void onResume() {
        super.onResume();
        AccountManager.getInstance().authenticateUserless();
        AccountManager.getInstance().loadUserData();
    }

 public void loadUserData() {
        new LoadUserDataTask(this).execute();
    }

    /**
     * Fetches user data from Reddit
     */
    private static class LoadUserDataTask extends AsyncTask<Void, Void, Account> {
        private WeakReference<AccountManager> weakAccountManager;

        private LoadUserDataTask(AccountManager weakAccountManager) {
            this.weakAccountManager = new WeakReference<>(weakAccountManager);
        }

        @Override
        protected Account doInBackground(Void... voids) {
            try {
                return App.getAccountHelper().getReddit().me().about();
            } catch (IllegalStateException e) {
                Log.e(TAG, "No user data found, continuing without one");
                return null;
            }
        }

        @Override
        protected void onPostExecute(Account data) {
            if (hasUser()) {
                for (onUserDataReceivedListener l : weakAccountManager.get().listenerList) {
                    l.onUserDataLoaded(data);
                }
            }
        }
    }

  AccountManager.getInstance().addOnUserDataReceivedListener(data -> {
            header.navHeaderUsername.setText(data.getName());
            header.navPostKarma.setText(String.valueOf(data.getLinkKarma()));
            header.navCommentKarma.setText(String.valueOf(data.getCommentKarma()));

            logInButton.setText(data.getName());
        });

[mpivchev]

So, any way to resolve this?

[mattbdean]

The reason RedditClient.me() throws an IllegalStateException is because the SelfUserReference constructor calls RedditClient.requireAuthenticatedUser(). This exception only gets thrown when in userless mode.

Since LoadUserDataTask.doInBackground returns null to handle IllegalStateExceptions, you can infer that if the Account passed to onPostExecute is null, there is no authenticated user.

[mpivchev]

True, but that doesn't explain why isUserless returns false, when clearly the app is in userless mode

[mattbdean]

Can you log the value of getAuthMethod()? Also Log.e takes a Throwable as a 3rd parameter, I'm going to need it's message and stacktrace.

[mpivchev]

Not quite sure what you mean by Log.e. Print the stacktrace of what?

Here is what it prints. I am userless since currentUsername returns <userless>, but isUserless says otherwise. If a user did exist, then Account.getName() wouldn't be null.

[mattbdean]

I think I've found the issue. When switchToUserless is called, it first tries to see if the TokenStore has an unexpired access token. If it finds one, it creates a new RedditClient with that data. The issue is that when it finds this data, it uses the wrong Credentials to instantiate it:

return switch(RedditClient(http, current, creds, tokenStore, username))

(source)

Here creds refers to the Credentials originally given to the AccountHelper (with AuthMethod APP). It should be using userlessCreds (with AuthMethod USERLESS_APP) instead.

I should have this fixed by tomorrow.

[mpivchev]

I think RedditClient.setAutoRenew doesn't work properly as well, since it didn't renew the access token automatically when I tried it today, so I'm forced to renew it manually. I will create a new issue tomorrow regarding this after testing a bit more.

[mattbdean]

Fixed! To use this patch you can either wait until v1.1.0 or use JitPack:

repositories {
    maven { url 'https://jitpack.io' }
}
dependencies {
    compile 'com.github.mattbdean:JRAW:6977732'
}

If you find an issue with setAutoRenew please submit a bug report so I can fix it!