Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VM Instruction Stream Checking #187

Open
matt-gretton-dann opened this issue May 24, 2021 · 0 comments
Open

Improve VM Instruction Stream Checking #187

matt-gretton-dann opened this issue May 24, 2021 · 0 comments
Assignees
@matt-gretton-dann
Labels
bc

Comments

@matt-gretton-dann
Copy link
Owner

The virtual machine in bc checks the incoming instruction stream for gross errors. We should
improve this, by:

  • Checking Offsets point to the correct data types.
  • Checking we have the same number of push_param_mark instructions as we have function calls
  • Every function definition has a pop_param_mark which is only executed once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt-gretton-dann matt-gretton-dann

Labels
bc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matt-gretton-dann