You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The bc length() function returns the length of a number in terms of the number of digits.
The current implementation assumes that this will fit in NumType and so be less than the base of
numbers we are storing. This is surprisingly limiting (esp. if NumType is 8- or 16-bits).
We should update this so that the maximum length is either:
base_ * base_log10_: That is you can have at most base_ underlying digits in the number
array; or
std::vector<>::max_size() * base_log10_: You can have Numbers as long as you like.
The
bc
length() function returns the length of a number in terms of the number of digits.The current implementation assumes that this will fit in
NumType
and so be less than the base ofnumbers we are storing. This is surprisingly limiting (esp. if
NumType
is 8- or 16-bits).We should update this so that the maximum length is either:
base_ * base_log10_
: That is you can have at mostbase_
underlying digits in the numberarray; or
std::vector<>::max_size() * base_log10_
: You can have Numbers as long as you like.Assignees: @matt-gretton-dann
Labels: bc
The text was updated successfully, but these errors were encountered: