Freight: Combine LSP and Carrier Shipment?

[kt86]

It is very confusing for me, because we have a lot of usage of LSPShipments, but in freight there are existing the CarrierShipments

In many steps, e.g. in the ScheduledShipmentLoad, ScheduledShipmentHandle, ScheduledShipmentUnload, a Carrier_Service_ is added .... (which is neither a LSPShipment not a CarrierShipment.

If we decide in the future to also use CarrierShipments (see matsim-vsp/logistics#44), the confusion is perfect :(

Maybe try in a first step to name everything that is related to an LSPShipment with lspShipment (instead of just shipment) ?? (Or do we already have a better idea? --> "job", "order", ... ?

(Update 24.11.2022)

• Rename all shipments entsprechend ihres Types -> lspShipment, carrierShipment
• Prüfe Datenstuktur von LSPShipment und CarrierShipment und wie man die zur Deckung bringen könnte, ggf. mit Attributen.
• Diskussion und Entscheidung mit KN: Führen wir das zusammen oder sagen wir, dass der LSP "Aufträge" / "Jobs" bekommt und die Shipments dann das sind, was zwischen den Carriern rumgereicht wird - da sind ja u.U interne Zeitfenster anders.
• Umsetzung dessen

---

After discussion witth KN:

Let's check, if we there is enough overlap between LSPShipment and CarrierShipment so we can condense it to just one type of Shipments.

If some fields are missing, we can use Attributes for it.

((The logistics repo goes into archive mode, code is not on matims-libs. So the issue is moved from - see there for more information: matsim-vsp/logistics#45 ))