Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt tests for Parking Search Contrib #3523

Closed
paulheinr opened this issue Oct 21, 2024 · 2 comments
Closed

Adapt tests for Parking Search Contrib #3523

paulheinr opened this issue Oct 21, 2024 · 2 comments
Assignees
@kainagel @paulheinr
Labels
code sprint Possible issue(s) for the MATSim code sprint maintenance things that should be done to improve code and UI

Comments

@paulheinr
Copy link
Contributor

paulheinr commented Oct 21, 2024 •
edited
Loading

There are integration tests in org.matsim.contrib.parking.parkingsearch.RunParkingSearchScenarioIT, but they don't really cover the parking search logics since some of them do not compare events.

Even with event comparison, no parking search was performed, because no parking facilities are registered - all activity types are "car interaction", but it should be "parking".
@paulheinr paulheinr converted this from a draft issue Oct 21, 2024
@paulheinr paulheinr added maintenance things that should be done to improve code and UI code sprint Possible issue(s) for the MATSim code sprint labels Oct 21, 2024
@paulheinr paulheinr self-assigned this Oct 21, 2024
@kainagel kainagel self-assigned this Nov 4, 2024
@paulheinr paulheinr mentioned this issue Nov 20, 2024
Open
@paulheinr
Copy link
Contributor Author

So far fixed:

  • Non-determinism of Benenson parking search AND distance memory parking search (used Math.random() instead of MatsimRanom before)
  • Implemented test case for 1 person and 100 persons for each strategy
    • Fix facilities such that parking is actually performed
    • Compare events and population for each test case

Still open:

  • Fix nearest parking spot search
  • Refactoring of classes for better readability

@paulheinr
Copy link
Contributor Author

See #3637

@paulheinr paulheinr moved this from In Progress to Done in MATSIM advanced weekly hackathon Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kainagel kainagel

@paulheinr paulheinr

Labels
code sprint Possible issue(s) for the MATSim code sprint maintenance things that should be done to improve code and UI
Projects
MATSIM advanced weekly hackathon
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kainagel @paulheinr