This repository has been archived by the owner on Mar 19, 2022. It is now read-only.
Print an error if a *_path configuration is not a String
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mat, could you take a look on this one, too? Other option would be to use |
| @@ -227,6 +227,8 @@ def upload_to_provision_path(src, dest, key_name = 'path') | |||
|
|
|||
| if src.nil? | |||
| Chef::Log.debug "'#{key_name}' not set" | |||
| elsif !src.respond_to?(:to_str) | |||
There was a problem hiding this comment.
I would have expected :to_s here (or maybe .is_a? String). What am I missing?
There was a problem hiding this comment.
As #to_s is defined already in Object, basically all object have it. So it would lead warnings about missing path (see my previous comment).
Googling lead me to use :to_str, which means that the object supports implicit conversion. But as it seems that String is the only Ruby core class that implements is, I agree that .is_a? String is less confusing. I'll make the change.
matschaffer
added a commit
that referenced
this pull request
Oct 19, 2013
Print an error if a `*_path` configuration is not a String
tmatilai
added a commit
to tmatilai/knife-solo
that referenced
this pull request
Nov 8, 2013
Chef 11.8.0 (with mixlib-config 2.0) sets `*_path` options by default based on `cookbook_path`. If it is an array (as always in knife-solo), the other paths are also arrays. And matschaffer#300 will catch that and error out. While the conversion to Array is a regression in Chef itself, we anyway want to set the default path relative to our kitchen root, as `cookbook_path` components might be pointing to somewhere else.
tmatilai
added a commit
to tmatilai/knife-solo
that referenced
this pull request
Nov 8, 2013
`node_path` made it back to Chef's default configuration in 11.8.0. And as pre 0.3.0 setups won't normally have it explicitly configured, it defaults to being an Array. Also a user might set it to be an Array, which leads knife-solo crashing with the infamous `ERROR: TypeError: no implicit conversion of Array into String`. This escaped from us in matschafferGH-300.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278